From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Zijun Hu <zijun_hu@icloud.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Tejun Heo <tj@kernel.org>, Josef Bacik <josef@toxicpanda.com>,
Jens Axboe <axboe@kernel.dk>, Boris Burkov <boris@bur.io>,
Davidlohr Bueso <dave@stgolabs.net>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
<linux-kernel@vger.kernel.org>, <cgroups@vger.kernel.org>,
<linux-block@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
Zijun Hu <quic_zijuhu@quicinc.com>
Subject: Re: [PATCH v4 8/8] driver core: Move 2 one line device finding APIs to header
Date: Tue, 24 Dec 2024 16:21:17 +0000 [thread overview]
Message-ID: <20241224162117.000046e7@huawei.com> (raw)
In-Reply-To: <39bb2acb-b003-43b1-af6d-81c99f6b47eb@icloud.com>
On Tue, 24 Dec 2024 20:33:44 +0800
Zijun Hu <zijun_hu@icloud.com> wrote:
> On 2024/12/24 04:11, Jonathan Cameron wrote:
> >> From: Zijun Hu <quic_zijuhu@quicinc.com>
> >>
> >> The following device finding APIs only have one line code in function body
> >> device_find_child_by_name()
> >> device_find_any_child()
> >>
> >> Move them to header as static inline function.
> > Why drop the docs?
> >
> thank you Jonathan for code review.
>
> will add these comments back in next revision.
>
> i do not notice the comments include important info, and think the API
> name prompts what the API does, so remove the comments. my mistake.
I don't mind that much, just that you should state your reasoning in the
patch description.
Jonathan
>
> >> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
>
>
prev parent reply other threads:[~2024-12-24 16:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 0:01 [PATCH v4 0/8] driver core: class: Fix bug and code improvements for class APIs Zijun Hu
2024-12-18 0:01 ` [PATCH v4 1/8] driver core: class: Fix wild pointer dereferences in API class_dev_iter_next() Zijun Hu
2024-12-23 20:09 ` Jonathan Cameron
2024-12-18 0:01 ` [PATCH v4 2/8] blk-cgroup: Fix class @block_class's subsystem refcount leakage Zijun Hu
2024-12-18 16:39 ` Tejun Heo
2024-12-18 0:01 ` [PATCH v4 3/8] driver core: Move true expression out of if condition in 3 device finding APIs Zijun Hu
2024-12-18 0:01 ` [PATCH v4 4/8] driver core: Rename declaration parameter name for API device_find_child() cluster Zijun Hu
2024-12-18 0:01 ` [PATCH v4 5/8] driver core: Correct parameter check for API device_for_each_child_reverse_from() Zijun Hu
2024-12-18 0:01 ` [PATCH v4 6/8] driver core: Correct API device_for_each_child_reverse_from() prototype Zijun Hu
2024-12-18 0:01 ` [PATCH v4 7/8] driver core: Introduce device_iter_t for device iterating APIs Zijun Hu
2024-12-18 0:01 ` [PATCH v4 8/8] driver core: Move 2 one line device finding APIs to header Zijun Hu
2024-12-23 20:11 ` Jonathan Cameron
2024-12-24 12:33 ` Zijun Hu
2024-12-24 16:21 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241224162117.000046e7@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=axboe@kernel.dk \
--cc=boris@bur.io \
--cc=cgroups@vger.kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_zijuhu@quicinc.com \
--cc=rafael@kernel.org \
--cc=tj@kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=zijun_hu@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).