From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH v2] block: Use enum for blk-mq tagset flags
Date: Fri, 3 Jan 2025 07:44:27 +0100 [thread overview]
Message-ID: <20250103064427.GA27984@lst.de> (raw)
In-Reply-To: <20250102144426.24241-1-john.g.garry@oracle.com>
On Thu, Jan 02, 2025 at 02:44:26PM +0000, John Garry wrote:
> Use an enum for tagset flags, so that they are automatically
> renumbered when modified and we don't potentially leave
> unused gaps. Some may find this neater.
Just as last time around I think this is a bad idea that just creates
more boilerplate. I actually wrote a series before my vacation to
drop another unused flag, remove the weirdo policy indiretion and
add better max flag checking while removing code. Let me rebase
that, finish writing commit log and send it out.
next prev parent reply other threads:[~2025-01-03 6:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 14:44 [PATCH v2] block: Use enum for blk-mq tagset flags John Garry
2025-01-03 6:44 ` Christoph Hellwig [this message]
2025-01-03 8:23 ` John Garry
2025-01-03 8:27 ` Christoph Hellwig
2025-01-03 8:38 ` John Garry
2025-01-03 15:13 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250103064427.GA27984@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).