From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [PATCH v2] block: Use enum for blk-mq tagset flags
Date: Fri, 3 Jan 2025 09:27:23 +0100 [thread overview]
Message-ID: <20250103082723.GA30419@lst.de> (raw)
In-Reply-To: <f3852e75-dff7-4cc9-b64c-01ebf1020808@oracle.com>
On Fri, Jan 03, 2025 at 08:23:02AM +0000, John Garry wrote:
> - better to not have unused gaps
Who cares?
> - catch missing blk-mq debugfs array names
> - this has been a problem in the past
Again who really cares?
>
> Cons:
> - boilerplate
>
> A compromise could be to use some macro to evaluate the flags, like:
> #define BLK_MQ_F(flag) (1 << BLK_MQ_B_##flag)
Hell no. The debugfs mess is already annoying as f**k because of
all that macro magic that makes it impossible to grep for. Don't
add more of that crap that just makes life hell.
next prev parent reply other threads:[~2025-01-03 8:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 14:44 [PATCH v2] block: Use enum for blk-mq tagset flags John Garry
2025-01-03 6:44 ` Christoph Hellwig
2025-01-03 8:23 ` John Garry
2025-01-03 8:27 ` Christoph Hellwig [this message]
2025-01-03 8:38 ` John Garry
2025-01-03 15:13 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250103082723.GA30419@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).