From: Christoph Hellwig <hch@lst.de>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Christoph Hellwig <hch@lst.de>,
Philipp Hortmann <philipp.g.hortmann@gmail.com>,
Geoff Levand <geoff@infradead.org>, Jens Axboe <axboe@kernel.dk>,
linuxppc-dev@lists.ozlabs.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ps3disk: Do not use dev->bounce_size before it is set
Date: Fri, 3 Jan 2025 09:56:52 +0100 [thread overview]
Message-ID: <20250103085652.GA31691@lst.de> (raw)
In-Reply-To: <06988f959ea6885b8bd7fb3b9059dd54bc6bbad7.1735894216.git.geert+renesas@glider.be>
On Fri, Jan 03, 2025 at 09:51:25AM +0100, Geert Uytterhoeven wrote:
> dev->bounce_size is only initialized after it is used to set the queue
> limits. Fix this by using BOUNCE_SIZE instead.
>
> Fixes: a7f18b74dbe17162 ("ps3disk: pass queue_limits to blk_mq_alloc_disk")
> Reported-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
> Closes: https://lore.kernel.org/39256db9-3d73-4e86-a49b-300dfd670212@gmail.com
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
But looking at the report it seems like no one cares about ps3 upstream,
and in fact the only person caring at all rather rants on youtube than
helping upstream, so maybe we should just remove the ps3 support entirely?
next prev parent reply other threads:[~2025-01-03 8:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 8:51 [PATCH] ps3disk: Do not use dev->bounce_size before it is set Geert Uytterhoeven
2025-01-03 8:56 ` Christoph Hellwig [this message]
2025-01-03 9:31 ` Geert Uytterhoeven
2025-01-03 18:45 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250103085652.GA31691@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=geert+renesas@glider.be \
--cc=geoff@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).