From: Christoph Hellwig <hch@lst.de>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Damien Le Moal <dlemoal@kernel.org>,
Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
nbd@other.debian.org, virtualization@lists.linux.dev,
linux-scsi@vger.kernel.org, usb-storage@lists.one-eyed-alien.net
Subject: Re: [PATCH 05/10] block: don't update BLK_FEAT_POLL in __blk_mq_update_nr_hw_queues
Date: Mon, 6 Jan 2025 16:27:08 +0100 [thread overview]
Message-ID: <20250106152708.GA27431@lst.de> (raw)
In-Reply-To: <3fb212e4-8fff-45fc-9cff-f5b5eaff4231@linux.ibm.com>
On Mon, Jan 06, 2025 at 05:36:52PM +0530, Nilay Shroff wrote:
> Oh yes, I saw that you moved blk_mq_can_poll() to blk-mq.h and
> made it inline so thought why bdev_can_poll() can't be made inline?
It can be, but why would you want it to? What do you gain from forcing
the compiler to inline it, when sane compilers with a sane inlining
threshold will do that anyway.
> BTW, bdev_can_poll() is called from IO fastpath and so making it inline
> may slightly improve performance.
> On another note, I do see that blk_mq_can_poll() is now only called
> from bdev_can_poll(). So you may want to merge these two functions
> in a single call and make that inline.
I'd rather keep generic block layer logic separate from blk-mq logic.
We tend to do a few direct calls into blk-mq from the core code to
avoid the indirect call overhead, but we should still keep the code
as separate as possible to keep it somewhat modular.
next prev parent reply other threads:[~2025-01-06 15:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 10:06 RFC: fix queue freeze and limit locking order (alt take) Christoph Hellwig
2025-01-06 10:06 ` [PATCH 01/10] block: fix docs for freezing of queue limits updates Christoph Hellwig
2025-01-06 10:39 ` Damien Le Moal
2025-01-06 10:06 ` [PATCH 02/10] block: add a queue_limits_commit_update_frozen helper Christoph Hellwig
2025-01-06 10:41 ` Damien Le Moal
2025-01-06 10:06 ` [PATCH 03/10] block: add a store_limit operations for sysfs entries Christoph Hellwig
2025-01-06 10:46 ` Damien Le Moal
2025-01-06 10:57 ` Christoph Hellwig
2025-01-06 10:06 ` [PATCH 04/10] block: use queue_limits_commit_update in queue_attr_store Christoph Hellwig
2025-01-06 10:48 ` Damien Le Moal
2025-01-06 10:06 ` [PATCH 05/10] block: don't update BLK_FEAT_POLL in __blk_mq_update_nr_hw_queues Christoph Hellwig
2025-01-06 10:55 ` Damien Le Moal
2025-01-06 10:59 ` Christoph Hellwig
2025-01-06 11:01 ` Nilay Shroff
2025-01-06 11:05 ` Christoph Hellwig
2025-01-06 12:06 ` Nilay Shroff
2025-01-06 15:27 ` Christoph Hellwig [this message]
2025-01-07 7:06 ` Nilay Shroff
2025-01-06 10:06 ` [PATCH 06/10] virtio_blk: use queue_limits_commit_update_frozen in cache_type_store Christoph Hellwig
2025-01-06 10:56 ` Damien Le Moal
2025-01-06 10:59 ` Christoph Hellwig
2025-01-06 13:09 ` Damien Le Moal
2025-01-06 15:27 ` Christoph Hellwig
2025-01-06 10:06 ` [PATCH 07/10] usb-storage: use queue_limits_commit_update_frozen in max_sectors_store Christoph Hellwig
2025-01-06 10:06 ` [PATCH 08/10] nvme: freeze queue after taking limits lock Christoph Hellwig
2025-01-06 10:06 ` [PATCH 09/10] loop: document why loop_clear_limits updates queue limits without freezing Christoph Hellwig
2025-01-06 10:06 ` [PATCH 10/10] nbd: use queue_limits_commit_update_frozen in nbd_set_size Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106152708.GA27431@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nbd@other.debian.org \
--cc=nilay@linux.ibm.com \
--cc=usb-storage@lists.one-eyed-alien.net \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).