Re: [PATCH v11 7/7] ufs: qcom: add support for wrapped keys

Eric Biggers
2025-02-10T16:21:20Z

On Mon, Feb 10, 2025 at 10:14:45AM +0530, Manivannan Sadhasivam wrote:
> On Mon, Feb 03, 2025 at 10:00:41PM -0800, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > Wire up the wrapped key support for ufs-qcom by implementing the needed
> > methods in struct blk_crypto_ll_ops and setting the appropriate flag in
> > blk_crypto_profile::key_types_supported.
> >
> > For more information about this feature and how to use it, refer to
> > the sections about hardware-wrapped keys in
> > Documentation/block/inline-encryption.rst and
> > Documentation/filesystems/fscrypt.rst.
> >
> > Based on patches by Gaurav Kashyap <quic_gaurkash@quicinc.com>.
> > Reworked to use the custom crypto profile support.
> >
>
> Instead of mentioning the contribution in description, you should use relevant
> tags IMO.

I had to rewrite this patch from scratch, and it is a much simpler
implementation of what was originally 6 patches. So in this case I don't think
it would make sense to keep authorship or co-developed-by.

- Eric