public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Gaurav Kashyap <quic_gaurkash@quicinc.com>,
	linux-fscrypt@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH v11 7/7] ufs: qcom: add support for wrapped keys
Date: Mon, 10 Feb 2025 08:21:18 -0800	[thread overview]
Message-ID: <20250210162118.GA1264@sol.localdomain> (raw)
In-Reply-To: <20250210044445.vmtfhqjibonhi6j2@thinkpad>

On Mon, Feb 10, 2025 at 10:14:45AM +0530, Manivannan Sadhasivam wrote:
> On Mon, Feb 03, 2025 at 10:00:41PM -0800, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> > 
> > Wire up the wrapped key support for ufs-qcom by implementing the needed
> > methods in struct blk_crypto_ll_ops and setting the appropriate flag in
> > blk_crypto_profile::key_types_supported.
> > 
> > For more information about this feature and how to use it, refer to
> > the sections about hardware-wrapped keys in
> > Documentation/block/inline-encryption.rst and
> > Documentation/filesystems/fscrypt.rst.
> > 
> > Based on patches by Gaurav Kashyap <quic_gaurkash@quicinc.com>.
> > Reworked to use the custom crypto profile support.
> > 
> 
> Instead of mentioning the contribution in description, you should use relevant
> tags IMO.

I had to rewrite this patch from scratch, and it is a much simpler
implementation of what was originally 6 patches.  So in this case I don't think
it would make sense to keep authorship or co-developed-by.

- Eric

  reply	other threads:[~2025-02-10 16:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-04  6:00 [PATCH v11 0/7] Support for hardware-wrapped inline encryption keys Eric Biggers
2025-02-04  6:00 ` [PATCH v11 1/7] blk-crypto: add basic hardware-wrapped key support Eric Biggers
2025-02-04  6:00 ` [PATCH v11 2/7] blk-crypto: show supported key types in sysfs Eric Biggers
2025-02-04  6:00 ` [PATCH v11 3/7] blk-crypto: add ioctls to create and prepare hardware-wrapped keys Eric Biggers
2025-02-04  6:00 ` [PATCH v11 4/7] fscrypt: add support for " Eric Biggers
2025-02-04  6:00 ` [PATCH v11 5/7] soc: qcom: ice: make qcom_ice_program_key() take struct blk_crypto_key Eric Biggers
2025-02-09 15:50   ` Manivannan Sadhasivam
2025-02-04  6:00 ` [PATCH v11 6/7] soc: qcom: ice: add HWKM support to the ICE driver Eric Biggers
2025-02-08 20:01   ` kernel test robot
2025-02-04  6:00 ` [PATCH v11 7/7] ufs: qcom: add support for wrapped keys Eric Biggers
2025-02-10  4:44   ` Manivannan Sadhasivam
2025-02-10 16:21     ` Eric Biggers [this message]
2025-02-04 10:42 ` [PATCH v11 0/7] Support for hardware-wrapped inline encryption keys Bartosz Golaszewski
2025-02-10 16:25 ` Eric Biggers
2025-02-10 16:54 ` (subset) " Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250210162118.GA1264@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=andersson@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=brgl@bgdev.pl \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=quic_gaurkash@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox