linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: shinichiro.kawasaki@wdc.com
Cc: linux-block@vger.kernel.org, hare@suse.de,
	patches@lists.linux.dev, gost.dev@samsung.com, mcgrof@kernel.org
Subject: [PATCH blktests v3 1/6] common/xfs: ignore first umount error on _xfs_mkfs_and_mount()
Date: Wed, 12 Feb 2025 12:54:43 -0800	[thread overview]
Message-ID: <20250212205448.2107005-2-mcgrof@kernel.org> (raw)
In-Reply-To: <20250212205448.2107005-1-mcgrof@kernel.org>

We want to help capture error messages with _xfs_mkfs_and_mount() on
$FULL, to do that we should avoid spamming error messages for things
which we know are not fatal. Such is the case of when we try to
mkfs a filesystem but before that try to umount the target path.
The first umount is just for sanity, so ignore the error messages from
it.

Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 common/xfs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/xfs b/common/xfs
index 569770fecd53..67a3b8a97391 100644
--- a/common/xfs
+++ b/common/xfs
@@ -15,7 +15,7 @@ _xfs_mkfs_and_mount() {
 	local mount_dir=$2
 
 	mkdir -p "${mount_dir}"
-	umount "${mount_dir}"
+	umount "${mount_dir}" >/dev/null 2>&1
 	mkfs.xfs -l size=64m -f "${bdev}" || return $?
 	mount "${bdev}" "${mount_dir}"
 }
-- 
2.45.2


  reply	other threads:[~2025-02-12 20:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-12 20:54 [PATCH blktests v3 0/6] enable bs > ps device testing Luis Chamberlain
2025-02-12 20:54 ` Luis Chamberlain [this message]
2025-02-12 20:58   ` [PATCH blktests v3 1/6] common/xfs: ignore first umount error on _xfs_mkfs_and_mount() Bart Van Assche
2025-02-12 21:07     ` Luis Chamberlain
2025-02-14 11:02       ` Shinichiro Kawasaki
2025-02-12 20:54 ` [PATCH blktests v3 2/6] block/032: make error messages clearer if mkfs or mount fails Luis Chamberlain
2025-02-14 11:06   ` Shinichiro Kawasaki
2025-02-12 20:54 ` [PATCH blktests v3 3/6] common: add and use min io for fio Luis Chamberlain
2025-02-14 11:24   ` Shinichiro Kawasaki
2025-02-12 20:54 ` [PATCH blktests v3 4/6] common/xfs: use min io for fs blocksize Luis Chamberlain
2025-02-12 20:54 ` [PATCH blktests v3 5/6] tests: use test device min io to support bs > ps Luis Chamberlain
2025-02-12 20:54 ` [PATCH blktests v3 6/6] common/xfs: add _test_dev_suits_xfs() to verify logical block size will work Luis Chamberlain
2025-02-14 11:28   ` Shinichiro Kawasaki
2025-02-14 11:34 ` [PATCH blktests v3 0/6] enable bs > ps device testing Shinichiro Kawasaki
2025-02-14 18:54   ` Luis Chamberlain
2025-02-21  9:55     ` Shinichiro Kawasaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250212205448.2107005-2-mcgrof@kernel.org \
    --to=mcgrof@kernel.org \
    --cc=gost.dev@samsung.com \
    --cc=hare@suse.de \
    --cc=linux-block@vger.kernel.org \
    --cc=patches@lists.linux.dev \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).