* [PATCH] block: Remove commented out code
@ 2025-02-19 20:53 Thorsten Blum
2025-02-20 6:07 ` Christoph Hellwig
2025-02-22 0:13 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Thorsten Blum @ 2025-02-19 20:53 UTC (permalink / raw)
To: Jens Axboe; +Cc: Thorsten Blum, linux-block, linux-kernel
Remove commented out code.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
block/partitions/sgi.c | 2 --
block/partitions/sun.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/block/partitions/sgi.c b/block/partitions/sgi.c
index 9cc6b8c1eea4..b5ecddd5181a 100644
--- a/block/partitions/sgi.c
+++ b/block/partitions/sgi.c
@@ -50,8 +50,6 @@ int sgi_partition(struct parsed_partitions *state)
p = &label->partitions[0];
magic = label->magic_mushroom;
if(be32_to_cpu(magic) != SGI_LABEL_MAGIC) {
- /*printk("Dev %s SGI disklabel: bad magic %08x\n",
- state->disk->disk_name, be32_to_cpu(magic));*/
put_dev_sector(sect);
return 0;
}
diff --git a/block/partitions/sun.c b/block/partitions/sun.c
index ddf9e6def4b2..2419af76120f 100644
--- a/block/partitions/sun.c
+++ b/block/partitions/sun.c
@@ -74,8 +74,6 @@ int sun_partition(struct parsed_partitions *state)
p = label->partitions;
if (be16_to_cpu(label->magic) != SUN_LABEL_MAGIC) {
-/* printk(KERN_INFO "Dev %s Sun disklabel: bad magic %04x\n",
- state->disk->disk_name, be16_to_cpu(label->magic)); */
put_dev_sector(sect);
return 0;
}
--
2.48.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] block: Remove commented out code
2025-02-19 20:53 [PATCH] block: Remove commented out code Thorsten Blum
@ 2025-02-20 6:07 ` Christoph Hellwig
2025-02-22 0:13 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2025-02-20 6:07 UTC (permalink / raw)
To: Thorsten Blum; +Cc: Jens Axboe, linux-block, linux-kernel
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] block: Remove commented out code
2025-02-19 20:53 [PATCH] block: Remove commented out code Thorsten Blum
2025-02-20 6:07 ` Christoph Hellwig
@ 2025-02-22 0:13 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2025-02-22 0:13 UTC (permalink / raw)
To: Thorsten Blum; +Cc: linux-block, linux-kernel
On Wed, 19 Feb 2025 21:53:25 +0100, Thorsten Blum wrote:
> Remove commented out code.
>
>
Applied, thanks!
[1/1] block: Remove commented out code
commit: 8985c4298733a56d38c11948dc3b1dd24f4fcd6b
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-22 0:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-19 20:53 [PATCH] block: Remove commented out code Thorsten Blum
2025-02-20 6:07 ` Christoph Hellwig
2025-02-22 0:13 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox