From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Nilay Shroff <nilay@linux.ibm.com>,
Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, dlemoal@kernel.org, axboe@kernel.dk,
gjoyce@ibm.com
Subject: Re: [PATCHv2 1/6] blk-sysfs: remove q->sysfs_lock for attributes which don't need it
Date: Mon, 24 Feb 2025 15:49:29 +0100 [thread overview]
Message-ID: <20250224144929.GA2205@lst.de> (raw)
In-Reply-To: <Z7nGw_PJfAld8fAz@fedora>
On Sat, Feb 22, 2025 at 08:44:51PM +0800, Ming Lei wrote:
> IMO, it is fine to read it lockless without READ_ONCE/WRITE_ONCE because
> disk->nr_zones is defined as 'unsigned int', which won't return garbage
> value anytime.
>
> But I don't object if you want to change to READ_ONCE/WRITE_ONCE.
It changes every time the disk capacity changes. And on the (uncommon)
reformats. So the best locking would be the same as for the disk
capacity.
next prev parent reply other threads:[~2025-02-24 14:49 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 8:28 [PATCHv2 0/6] block: fix lock order and remove redundant locking Nilay Shroff
2025-02-18 8:28 ` [PATCHv2 1/6] blk-sysfs: remove q->sysfs_lock for attributes which don't need it Nilay Shroff
2025-02-18 8:46 ` Christoph Hellwig
2025-02-18 11:26 ` Nilay Shroff
2025-02-21 14:02 ` Nilay Shroff
2025-02-22 12:44 ` Ming Lei
2025-02-24 13:09 ` Nilay Shroff
2025-02-24 14:49 ` Christoph Hellwig [this message]
2025-02-26 12:09 ` Nilay Shroff
2025-02-24 8:41 ` Hannes Reinecke
2025-02-24 13:12 ` Nilay Shroff
2025-02-18 12:10 ` Ming Lei
2025-02-18 13:11 ` Nilay Shroff
2025-02-18 13:45 ` Ming Lei
2025-02-18 16:29 ` Christoph Hellwig
2025-02-19 3:24 ` Ming Lei
2025-02-19 5:42 ` Christoph Hellwig
2025-02-19 8:34 ` Nilay Shroff
2025-02-19 8:56 ` Nilay Shroff
2025-02-19 9:20 ` Ming Lei
2025-02-18 8:28 ` [PATCHv2 2/6] blk-sysfs: acquire q->limits_lock while reading attributes Nilay Shroff
2025-02-18 8:46 ` Christoph Hellwig
2025-02-18 8:28 ` [PATCHv2 3/6] block: Introduce a dedicated lock for protecting queue elevator updates Nilay Shroff
2025-02-18 9:05 ` Christoph Hellwig
2025-02-18 11:14 ` Nilay Shroff
2025-02-18 16:32 ` Christoph Hellwig
2025-02-19 8:41 ` Nilay Shroff
2025-02-18 8:28 ` [PATCHv2 4/6] blk-sysfs: protect nr_requests update using q->elevator_lock Nilay Shroff
2025-02-18 8:28 ` [PATCHv2 5/6] blk-sysfs: protect wbt_lat_usec " Nilay Shroff
2025-02-18 8:28 ` [PATCHv2 6/6] blk-sysfs: protect read_ahead_kb using q->limits_lock Nilay Shroff
2025-02-18 9:12 ` Christoph Hellwig
2025-02-18 11:27 ` Nilay Shroff
2025-02-18 9:21 ` [PATCHv2 0/6] block: fix lock order and remove redundant locking Christoph Hellwig
2025-02-18 12:09 ` Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250224144929.GA2205@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=gjoyce@ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nilay@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).