From: Christoph Hellwig <hch@lst.de>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: linux-block@vger.kernel.org, hch@lst.de, ming.lei@redhat.com,
dlemoal@kernel.org, hare@suse.de, axboe@kernel.dk,
gjoyce@ibm.com
Subject: Re: [PATCHv4 4/7] block: Introduce a dedicated lock for protecting queue elevator updates
Date: Tue, 25 Feb 2025 16:12:08 +0100 [thread overview]
Message-ID: <20250225151208.GA6455@lst.de> (raw)
In-Reply-To: <20250225133110.1441035-5-nilay@linux.ibm.com>
This still has the capitalization of the first letter after the block:
prefix in the subject line.
> + * Attributes which require some form of locking
> + * other than q->sysfs_lock.
Nit: "other than" easily fits on the previous line.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-02-25 15:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 13:30 [PATCHv4 0/7] block: fix lock order and remove redundant locking Nilay Shroff
2025-02-25 13:30 ` [PATCHv4 1/7] block: acquire q->limits_lock while reading sysfs attributes Nilay Shroff
2025-02-25 13:30 ` [PATCHv4 2/7] block: move q->sysfs_lock and queue-freeze under show/store method Nilay Shroff
2025-02-25 13:30 ` [PATCHv4 3/7] block: remove q->sysfs_lock for attributes which don't need it Nilay Shroff
2025-02-25 13:30 ` [PATCHv4 4/7] block: Introduce a dedicated lock for protecting queue elevator updates Nilay Shroff
2025-02-25 15:12 ` Christoph Hellwig [this message]
2025-02-26 12:12 ` Nilay Shroff
2025-02-25 13:30 ` [PATCHv4 5/7] block: protect nr_requests update using q->elevator_lock Nilay Shroff
2025-02-25 13:30 ` [PATCHv4 6/7] block: protect wbt_lat_usec " Nilay Shroff
2025-02-25 15:13 ` Christoph Hellwig
2025-02-26 12:11 ` Nilay Shroff
2025-02-26 7:33 ` Hannes Reinecke
2025-02-25 13:30 ` [PATCHv4 7/7] block: protect read_ahead_kb using q->limits_lock Nilay Shroff
2025-02-25 15:14 ` Christoph Hellwig
2025-02-26 12:10 ` Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250225151208.GA6455@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=gjoyce@ibm.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nilay@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).