From: Christoph Hellwig <hch@lst.de>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: linux-block@vger.kernel.org, ming.lei@redhat.com,
dlemoal@kernel.org, hare@suse.de, axboe@kernel.dk,
gjoyce@ibm.com
Subject: Re: [PATCH] block: protect debugfs attributes using q->elevator_lock
Date: Thu, 13 Mar 2025 08:54:21 +0100 [thread overview]
Message-ID: <20250313075421.GA12286@lst.de> (raw)
In-Reply-To: <9e5fd5f1-1564-4a99-aeb4-6d8d9d765db7@linux.ibm.com>
On Wed, Mar 12, 2025 at 08:49:33PM +0530, Nilay Shroff wrote:
> > really want this read system call interrupted by random signals, do
> > we? I guess this should be mutex_lock_killable.
> >
> > (and the same for the existing methods this is copy and pasted from).
> >
> I thought we wanted to interrupt using SIGINT (CTRL+C) in case user opens
> this file using cat. Maybe that's more convenient than sending SIGKILL.
> And yes I used mutex_lock_interruptible because for other attributes we are
> already using it. But if mutex_lock_killable is preferred then I'd change it
> for all methods.
Let's leave it alone for this series. While I think it's the wrong
choice it's been there for a long time, so we might as well not change
it now for unrelated reasons.
next prev parent reply other threads:[~2025-03-13 7:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 10:28 [PATCH] block: protect debugfs attributes using q->elevator_lock Nilay Shroff
2025-03-12 10:51 ` Damien Le Moal
2025-03-12 11:03 ` Nilay Shroff
2025-03-12 11:08 ` Nilay Shroff
2025-03-12 14:12 ` Christoph Hellwig
2025-03-12 15:19 ` Nilay Shroff
2025-03-13 7:54 ` Christoph Hellwig [this message]
2025-03-13 11:48 ` Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250313075421.GA12286@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=gjoyce@ibm.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nilay@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox