Re: [PATCH 0/2] ublk: specify io_cmd_buf pointer type

Ming Lei
2025-03-29T00:25:10Z

On Fri, Mar 28, 2025 at 01:42:28PM -0600, Caleb Sander Mateos wrote:
> io_cmd_buf points to an array of ublksrv_io_desc structs but its type is
> char *. Indexing the array requires an explicit multiplication and cast.
> The compiler also can't check the pointer types.
>
> Change io_cmd_buf's type to struct ublksrv_io_desc * so it can be
> indexed directly and the compiler can type-check the code.
>
> Make the same change to the ublk selftests.
>
> Caleb Sander Mateos (2):
> ublk: specify io_cmd_buf pointer type
> selftests: ublk: specify io_cmd_buf pointer type
>
> drivers/block/ublk_drv.c | 8 ++++----
> tools/testing/selftests/ublk/kublk.c | 2 +-
> tools/testing/selftests/ublk/kublk.h | 4 ++--
> 3 files changed, 7 insertions(+), 7 deletions(-)

Reviewed-by: Ming Lei <ming.lei@redhat.com>

Thanks,
Ming