From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: "Jens Axboe" <axboe@kernel.dk>,
linux-block@vger.kernel.org,
"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
"Nilay Shroff" <nilay@linux.ibm.com>,
"Christoph Hellwig" <hch@lst.de>
Subject: Re: [PATCH V2 2/3] block: don't call freeze queue in elevator_switch() and elevator_disable()
Date: Thu, 3 Apr 2025 07:36:10 +0200 [thread overview]
Message-ID: <20250403053610.GA24133@lst.de> (raw)
In-Reply-To: <20250403025214.1274650-3-ming.lei@redhat.com>
On Thu, Apr 03, 2025 at 10:52:09AM +0800, Ming Lei wrote:
> Both elevator_switch() and elevator_disable() are called from sysfs
> store and updating nr_hw_queue code paths only.
>
> And in the two code paths, queue has been frozen already, so don't call
> freeze queue in the two functions.
This looks good, but please add asserts that the queue is in the
proper frozen state in both places. Also please move it first as
it doesn't depend on the previous patch.
next prev parent reply other threads:[~2025-04-03 5:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 2:52 [PATCH V2 0/3] block: fix lock dependency between freeze and elevator lock Ming Lei
2025-04-03 2:52 ` [PATCH V2 1/3] block: add blk_mq_enter_no_io() and blk_mq_exit_no_io() Ming Lei
2025-04-03 5:44 ` Christoph Hellwig
2025-04-03 10:22 ` Ming Lei
2025-04-03 2:52 ` [PATCH V2 2/3] block: don't call freeze queue in elevator_switch() and elevator_disable() Ming Lei
2025-04-03 5:36 ` Christoph Hellwig [this message]
2025-04-03 2:52 ` [PATCH V2 3/3] block: use blk_mq_no_io() for avoiding lock dependency Ming Lei
2025-04-03 5:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250403053610.GA24133@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nilay@linux.ibm.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox