From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: "Jens Axboe" <axboe@kernel.dk>,
linux-block@vger.kernel.org,
"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
"Nilay Shroff" <nilay@linux.ibm.com>,
"Christoph Hellwig" <hch@lst.de>,
syzbot+4c7e0f9b94ad65811efb@syzkaller.appspotmail.com
Subject: Re: [PATCH V2 3/3] block: use blk_mq_no_io() for avoiding lock dependency
Date: Thu, 3 Apr 2025 07:44:57 +0200 [thread overview]
Message-ID: <20250403054457.GC24133@lst.de> (raw)
In-Reply-To: <20250403025214.1274650-4-ming.lei@redhat.com>
On Thu, Apr 03, 2025 at 10:52:10AM +0800, Ming Lei wrote:
> Lock implied in blk_mq_enter_no_io() won't connect with any lock in IO
> code paths now, so use it to prevent IO from entering queue for avoiding
> lock dependency between freeze lock and elevator lock, and we have got
> many such reports.
Please explain what this actually fixes here.
prev parent reply other threads:[~2025-04-03 5:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 2:52 [PATCH V2 0/3] block: fix lock dependency between freeze and elevator lock Ming Lei
2025-04-03 2:52 ` [PATCH V2 1/3] block: add blk_mq_enter_no_io() and blk_mq_exit_no_io() Ming Lei
2025-04-03 5:44 ` Christoph Hellwig
2025-04-03 10:22 ` Ming Lei
2025-04-03 2:52 ` [PATCH V2 2/3] block: don't call freeze queue in elevator_switch() and elevator_disable() Ming Lei
2025-04-03 5:36 ` Christoph Hellwig
2025-04-03 2:52 ` [PATCH V2 3/3] block: use blk_mq_no_io() for avoiding lock dependency Ming Lei
2025-04-03 5:44 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250403054457.GC24133@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nilay@linux.ibm.com \
--cc=syzbot+4c7e0f9b94ad65811efb@syzkaller.appspotmail.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox