From: Christoph Hellwig <hch@lst.de>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
kbusch@kernel.org, hare@suse.de, sagi@grimberg.me,
jmeneghi@redhat.com, axboe@kernel.dk, gjoyce@ibm.com
Subject: Re: [RFC PATCH 2/2] nvme-multipath: remove multipath module param
Date: Tue, 22 Apr 2025 09:36:54 +0200 [thread overview]
Message-ID: <20250422073654.GB31849@lst.de> (raw)
In-Reply-To: <e50e568c-9a9b-4306-a2f4-e108791e83d2@linux.ibm.com>
On Fri, Apr 18, 2025 at 07:52:06PM +0530, Nilay Shroff wrote:
> I don't know how to make this option per-controller as you know the
> head node, typically, refers to namespace paths and each path then
> refers to different controller. So if we were to make this option
> per controller then how could we handle it in case one controller has
> this option set but then the another controller doesn't set this
> option. It could be confusing.
>
> How about module option "nvme_core.multipath_head_always"? The default is
> set to false. So now it becomes two step process:
> 1. modprobe nvme_core multipath_head_always=Y && modprobe nvme
> 2. echo "<val>" > /sys/block/nvme0XnY/delayed_shutdown_sec
That's probably the best we can do.
prev parent reply other threads:[~2025-04-22 7:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 6:37 [RFC PATCH 0/2] improve NVMe multipath handling Nilay Shroff
2025-03-21 6:37 ` [RFC PATCH 1/2] nvme-multipath: introduce delayed removal of the multipath head node Nilay Shroff
2025-03-22 1:48 ` Martin K. Petersen
2025-03-22 22:08 ` Nilay Shroff
2025-03-25 15:21 ` John Meneghini
2025-04-07 14:44 ` Christoph Hellwig
2025-04-08 14:07 ` Nilay Shroff
2025-04-09 10:43 ` Christoph Hellwig
2025-04-18 10:45 ` Nilay Shroff
2025-04-22 7:36 ` Christoph Hellwig
2025-04-22 9:52 ` Nilay Shroff
2025-03-21 6:37 ` [RFC PATCH 2/2] nvme-multipath: remove multipath module param Nilay Shroff
2025-03-25 15:09 ` John Meneghini
2025-04-07 14:45 ` Christoph Hellwig
2025-04-08 14:35 ` Nilay Shroff
2025-04-09 10:45 ` Christoph Hellwig
2025-04-18 14:22 ` Nilay Shroff
2025-04-22 7:36 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250422073654.GB31849@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=gjoyce@ibm.com \
--cc=hare@suse.de \
--cc=jmeneghi@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).