Re: [PATCH v8 05/15] xfs: ignore HW which cannot atomic write a single block

Christoph Hellwig
2025-04-23T08:33:21Z

On Wed, Apr 23, 2025 at 09:28:14AM +0100, John Garry wrote:
>> But maybe we should just delay setting the atomic values until later so
>> that it can be done in a single pass? E.g. into xfs_setsize_buftarg
>> which then should probably be rename to something like
>> xfs_buftarg_setup.
>>
>
> How about just do away with btp->bt_bdev_awu_{min, max} struct members, and
> call bdev_atomic_write_unit_max(mp->m_ddev_targp->bt_bdev) [and same for
> RT] to later to set the mp awu max values at mountfs time? I think that
> would work..

Sounds reasonable.