Re: [PATCH v8 11/15] xfs: commit CoW-based atomic writes atomically

Christoph Hellwig
2025-04-23T08:23:12Z

On Tue, Apr 22, 2025 at 12:27:35PM +0000, John Garry wrote:
> +STATIC void

Didn't we phase out STATIC for new code?

> +xfs_calc_default_atomic_ioend_reservation(
> + struct xfs_mount *mp,
> + struct xfs_trans_resv *resp)
> +{
> + if (xfs_has_reflink(mp))
> + resp->tr_atomic_ioend = resp->tr_itruncate;
> + else
> + memset(&resp->tr_atomic_ioend, 0,
> + sizeof(resp->tr_atomic_ioend));
> +}

What is the point of zeroing out the structure for the non-reflink
case? Just as a poision for not using it when not supported as no
code should be doing that? Just thinking of this because it is a
potentially nasty landmine for the zoned atomic support.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>