Re: [PATCH v8 10/15] xfs: add large atomic writes checks in xfs_direct_write_iomap_begin()

John Garry
2025-04-23T08:18:39Z

On 23/04/2025 09:16, Christoph Hellwig wrote:
> On Tue, Apr 22, 2025 at 12:27:34PM +0000, John Garry wrote:
>> For when large atomic writes (> 1x FS block) are supported, there will be
>> various occasions when HW offload may not be possible.
>>
>> Such instances include:
>> - unaligned extent mapping wrt write length
>> - extent mappings which do not cover the full write, e.g. the write spans
>> sparse or mixed-mapping extents
>> - the write length is greater than HW offload can support
>
> or simply no hardware support at all.

sure, will add

>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

cheers