Re: [PATCH v9 05/15] xfs: ignore HW which cannot atomic write a single block

Christoph Hellwig
2025-04-29T12:21:10Z

On Fri, Apr 25, 2025 at 04:44:54PM +0000, John Garry wrote:
> + /* Configure hardware atomic write geometry */
> + xfs_buftarg_config_atomic_writes(mp->m_ddev_targp);
> + if (mp->m_logdev_targp && mp->m_logdev_targp != mp->m_ddev_targp)
> + xfs_buftarg_config_atomic_writes(mp->m_logdev_targp);
> + if (mp->m_rtdev_targp && mp->m_rtdev_targp != mp->m_ddev_targp)
> + xfs_buftarg_config_atomic_writes(mp->m_rtdev_targp);

So this can't be merged into xfs_setsize_buftarg as suggeted last round
instead of needing yet another per-device call into the buftarg code?