* [PATCH blktests] nvme/63: fixup tls_key encryption check
@ 2025-05-08 23:44 Wilfred Mallawa
2025-05-15 12:32 ` Shinichiro Kawasaki
0 siblings, 1 reply; 2+ messages in thread
From: Wilfred Mallawa @ 2025-05-08 23:44 UTC (permalink / raw)
To: shinichiro.kawasaki, linux-block
Cc: dlemoal, hare, yi.zhang, alistair.francis, wilfred.mallawa
From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
The _nvme_ctrl_tls_key function returns 0 if `tls_key` exists in sysfs for
the respective nvme controller. This will be evaluated as true. However,
the test should error only if the key is not exposed by sysfs. Which
would mean the connection is not encrypted, as per the existing warning
message in the test. Currently, we are checking that it exists and
erroring out incorrectly. This patch fixes the above.
Link: https://github.com/osandov/blktests/issues/168
Fixes: 9aa2023312bf ("nvme: add testcase for secure concatenation")
Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
---
tests/nvme/063 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/nvme/063 b/tests/nvme/063
index 7477078..5bfe8be 100755
--- a/tests/nvme/063
+++ b/tests/nvme/063
@@ -93,7 +93,7 @@ test() {
_nvme_connect_subsys --dhchap-secret "${hostkey}" --concat
ctrl=$(_find_nvme_dev "${def_subsysnqn}")
- if _nvme_ctrl_tls_key "$ctrl" > /dev/null ; then
+ if ! _nvme_ctrl_tls_key "$ctrl" > /dev/null ; then
echo "WARNING: connection is not encrypted"
_systemctl_stop
return 1
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH blktests] nvme/63: fixup tls_key encryption check
2025-05-08 23:44 [PATCH blktests] nvme/63: fixup tls_key encryption check Wilfred Mallawa
@ 2025-05-15 12:32 ` Shinichiro Kawasaki
0 siblings, 0 replies; 2+ messages in thread
From: Shinichiro Kawasaki @ 2025-05-15 12:32 UTC (permalink / raw)
To: Wilfred Mallawa
Cc: linux-block@vger.kernel.org, dlemoal@kernel.org, hare@suse.de,
yi.zhang@redhat.com, Alistair Francis, Wilfred Mallawa
On May 09, 2025 / 09:44, Wilfred Mallawa wrote:
> From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
>
> The _nvme_ctrl_tls_key function returns 0 if `tls_key` exists in sysfs for
> the respective nvme controller. This will be evaluated as true. However,
> the test should error only if the key is not exposed by sysfs. Which
> would mean the connection is not encrypted, as per the existing warning
> message in the test. Currently, we are checking that it exists and
> erroring out incorrectly. This patch fixes the above.
>
> Link: https://github.com/osandov/blktests/issues/168
> Fixes: 9aa2023312bf ("nvme: add testcase for secure concatenation")
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
I applied it. Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-15 12:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-08 23:44 [PATCH blktests] nvme/63: fixup tls_key encryption check Wilfred Mallawa
2025-05-15 12:32 ` Shinichiro Kawasaki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).