From: Jason Xing <kerneljasonxing@gmail.com>
To: axboe@kernel.dk, rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>,
Yushan Zhou <katrinzhou@tencent.com>
Subject: [PATCH v2 2/4] relayfs: introduce dump of relayfs statistics function
Date: Thu, 15 May 2025 14:16:41 +0800 [thread overview]
Message-ID: <20250515061643.31472-3-kerneljasonxing@gmail.com> (raw)
In-Reply-To: <20250515061643.31472-1-kerneljasonxing@gmail.com>
From: Jason Xing <kernelxing@tencent.com>
In this version, only support dumping the counter for buffer full and
implement the framework of how it works.
Users can pass certain flag to fetch what field/statistics they expect
to know. Each time it only returns one result. So do not pass multiple
flags.
Reviewed-by: Yushan Zhou <katrinzhou@tencent.com>
Signed-off-by: Jason Xing <kernelxing@tencent.com>
---
v2
1. refactor relay_dump() and make it only return a pure size_t result
of the value that users specifies.
2. revise the commit log.
---
include/linux/relay.h | 7 +++++++
kernel/relay.c | 31 +++++++++++++++++++++++++++++++
2 files changed, 38 insertions(+)
diff --git a/include/linux/relay.h b/include/linux/relay.h
index ce7a1b396872..3fb285716e34 100644
--- a/include/linux/relay.h
+++ b/include/linux/relay.h
@@ -31,6 +31,12 @@
/*
* Relay buffer statistics dump
*/
+enum {
+ RELAY_DUMP_BUF_FULL = (1 << 0),
+
+ RELAY_DUMP_LAST = RELAY_DUMP_BUF_FULL,
+};
+
struct rchan_buf_stats
{
unsigned int full_count; /* counter for buffer full */
@@ -167,6 +173,7 @@ struct rchan *relay_open(const char *base_filename,
void *private_data);
extern void relay_close(struct rchan *chan);
extern void relay_flush(struct rchan *chan);
+extern size_t relay_dump(struct rchan *chan, int flags);
extern void relay_subbufs_consumed(struct rchan *chan,
unsigned int cpu,
size_t consumed);
diff --git a/kernel/relay.c b/kernel/relay.c
index eb3f630f3896..f47fc750e559 100644
--- a/kernel/relay.c
+++ b/kernel/relay.c
@@ -701,6 +701,37 @@ void relay_flush(struct rchan *chan)
}
EXPORT_SYMBOL_GPL(relay_flush);
+/**
+ * relay_dump - dump channel buffer statistics
+ * @chan: the channel
+ * @flags: select particular information to dump
+ *
+ * Returns the count of certain field that caller specifies.
+ */
+size_t relay_dump(struct rchan *chan, int flags)
+{
+ unsigned int i, count = 0;
+ struct rchan_buf *rbuf;
+
+ if (!chan || flags > RELAY_DUMP_LAST)
+ return 0;
+
+ if (chan->is_global) {
+ rbuf = *per_cpu_ptr(chan->buf, 0);
+ if (flags & RELAY_DUMP_BUF_FULL)
+ count = rbuf->stats.full_count;
+ } else {
+ for_each_online_cpu(i) {
+ if ((rbuf = *per_cpu_ptr(chan->buf, i)))
+ if (flags & RELAY_DUMP_BUF_FULL)
+ count += rbuf->stats.full_count;
+ }
+ }
+
+ return count;
+}
+EXPORT_SYMBOL_GPL(relay_dump);
+
/**
* relay_file_open - open file op for relay files
* @inode: the inode
--
2.43.5
next prev parent reply other threads:[~2025-05-15 6:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 6:16 [PATCH v2 0/4] relayfs: misc changes Jason Xing
2025-05-15 6:16 ` [PATCH v2 1/4] relayfs: support a counter tracking if per-cpu buffers is full Jason Xing
2025-05-15 18:17 ` Jens Axboe
2025-05-15 6:16 ` Jason Xing [this message]
2025-05-15 18:19 ` [PATCH v2 2/4] relayfs: introduce dump of relayfs statistics function Jens Axboe
2025-05-15 23:24 ` Jason Xing
2025-05-16 2:08 ` Masami Hiramatsu
2025-05-16 2:32 ` Jason Xing
2025-05-16 4:37 ` Christoph Hellwig
2025-05-16 5:02 ` Jason Xing
2025-05-16 5:06 ` Christoph Hellwig
2025-05-16 5:44 ` Jason Xing
2025-05-15 6:16 ` [PATCH v2 3/4] blktrace: use rbuf->stats.full as a drop indicator in relayfs Jason Xing
2025-05-15 18:19 ` Jens Axboe
2025-05-15 18:21 ` Jens Axboe
2025-05-15 23:26 ` Jason Xing
2025-05-15 6:16 ` [PATCH v2 4/4] relayfs: support a counter tracking if data is too big to write Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250515061643.31472-3-kerneljasonxing@gmail.com \
--to=kerneljasonxing@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=katrinzhou@tencent.com \
--cc=kernelxing@tencent.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox