From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] block: Reduce the scope of a variable in __blk_mq_update_nr_hw_queues()
Date: Fri, 27 Jun 2025 09:18:33 +0200 [thread overview]
Message-ID: <20250627071833.GA1103@lst.de> (raw)
In-Reply-To: <20250626212201.2271832-1-bvanassche@acm.org>
On Thu, Jun 26, 2025 at 02:22:01PM -0700, Bart Van Assche wrote:
> Improve code readability by reducing the scope of the variable 'i'.
>
> This patch fixes the following W=2 compiler warning:
>
> block/blk-mq.c:5037:8: error: declaration shadows a local variable [-Werror,-Wshadow]
> 5037 | int i = prev_nr_hw_queues;
> | ^
> block/blk-mq.c:4999:6: note: previous declaration is here
> 4999 | int i;
If we want to fix this renaming one variable is much better.
But Nilay is currently active with major changes to this area, let's
delay cosmetic fixes until that has landed.
prev parent reply other threads:[~2025-06-27 7:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 21:22 [PATCH] block: Reduce the scope of a variable in __blk_mq_update_nr_hw_queues() Bart Van Assche
2025-06-27 7:18 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250627071833.GA1103@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox