From: Christian Brauner <brauner@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Christoph Hellwig <hch@infradead.org>,
Arnd Bergmann <arnd@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
Anuj Gupta <anuj20.g@samsung.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Kanchan Joshi <joshi.k@samsung.com>,
LTP List <ltp@lists.linux.it>,
Dan Carpenter <dan.carpenter@linaro.org>,
Benjamin Copeland <benjamin.copeland@linaro.org>,
rbm@suse.com, Naresh Kamboju <naresh.kamboju@linaro.org>,
Anders Roxell <anders.roxell@linaro.org>,
Jens Axboe <axboe@kernel.dk>,
Pavel Begunkov <asml.silence@gmail.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Eric Biggers <ebiggers@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: fix FS_IOC_GETLBMD_CAP parsing in blkdev_common_ioctl()
Date: Thu, 10 Jul 2025 14:11:26 +0200 [thread overview]
Message-ID: <20250710-ehegatte-undicht-6b71310cb1ef@brauner> (raw)
In-Reply-To: <14865b4a-dfad-4336-9113-b70d65c9ad52@app.fastmail.com>
> Christian's version using the copy_struct_{from,to}_user()
> aims to avoid most of the problems. The main downside I see
> here is the extra complexity in the kernel. As far as I can
> tell, this has mainly led to extra kernel bugs but has not
> actually resulted in any structure getting seamlessly
> extended.
We extended ioctls multiple times seemlessly and other than this bug
right here I'm not aware of anything serious. Not liking it is fine of
course but saying "this caused a bug so go away" I won't take all too
seriously, sorry.
I don't want to go down the road of structure revisions for stuff in the
generic layer. Others can do whatever they see fit ofc and userspace can
then have its usualy ifdeffery and structure layout detection party
instead of a clean generic solution. I'd rather clean up the necessary
vetting bits and properly document how this can be done.
next prev parent reply other threads:[~2025-07-10 12:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 18:10 [PATCH] block: fix FS_IOC_GETLBMD_CAP parsing in blkdev_common_ioctl() Arnd Bergmann
2025-07-09 18:27 ` Darrick J. Wong
2025-07-09 20:30 ` Arnd Bergmann
2025-07-10 8:00 ` Christian Brauner
2025-07-10 8:14 ` Christoph Hellwig
2025-07-10 10:50 ` Arnd Bergmann
2025-07-10 10:59 ` Christoph Hellwig
2025-07-10 11:52 ` Arnd Bergmann
2025-07-10 12:11 ` Christian Brauner [this message]
2025-07-10 10:11 ` Arnd Bergmann
2025-07-10 12:03 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250710-ehegatte-undicht-6b71310cb1ef@brauner \
--to=brauner@kernel.org \
--cc=adobriyan@gmail.com \
--cc=anders.roxell@linaro.org \
--cc=anuj20.g@samsung.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=benjamin.copeland@linaro.org \
--cc=dan.carpenter@linaro.org \
--cc=djwong@kernel.org \
--cc=ebiggers@google.com \
--cc=hch@infradead.org \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=martin.petersen@oracle.com \
--cc=naresh.kamboju@linaro.org \
--cc=rbm@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox