From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 004.mia.mailroute.net (004.mia.mailroute.net [199.89.3.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B45D3EEBB; Thu, 17 Jul 2025 20:59:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.3.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752785951; cv=none; b=YN66wEFg+xEphyDaLGByPH0O2OLVWChqUjvhupdIGaijJkY2XusclYP/oWrx2fyJGrSd9vnxO4hvt/NRDGLHZIfiIb9JGC6WVfusjuX65cxVsQFwapuYhmn3ZzKzWm++d8rB+Z8TDfp8x1uvUw0lXkjU1lIAi7Om4RaP7QSNYkE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752785951; c=relaxed/simple; bh=bw8A8RkN5uWujw34L+A2FOvu6j04Y8yJHkS2Lr2WfLo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fu/YJ4Sy2xv+Xknjh/c7VbBBQSmF2Xxj+hgzqXkYm7LbEtJ8kt+fwt3yzPHRzCNpyHeBFkOOa0IgBn7QRkaJ+j0uAVCFMsiXGsKGNtQo6ulthkq4K5LwQfJa93LnOoRte3eR6mokropqtRwsnzZNJiOrddB/V05NE+KMJbH1YRo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=4C0pYBLy; arc=none smtp.client-ip=199.89.3.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="4C0pYBLy" Received: from localhost (localhost [127.0.0.1]) by 004.mia.mailroute.net (Postfix) with ESMTP id 4bjlf45zgczm0yQd; Thu, 17 Jul 2025 20:59:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:mime-version:references:in-reply-to :x-mailer:message-id:date:date:subject:subject:from:from :received:received; s=mr01; t=1752785947; x=1755377948; bh=D6ehn dv1nG83Yo9C9XQqD7yY8y/YUn+6yBLL6+isFx0=; b=4C0pYBLylgjCzMwD7JEas +FIxcvnNIplFlB1HxNUaRO6cDeLSc6lhogvJ4YRFmxawbZ7YXMTV04yPAFXTgjf+ oSbbujvDZZIKPTMeyy3VGWTxFJgIRKjg+FnXhEu05lkRqN5YkZn0lzBwEwz0KL0z xRtr27bwZMK9XmkGLDy4G+hRMd+6wpkyLQFLsZgbP/I+ZG81M2QCDXMHM0yEUnE6 y+zjf9M7rd5OWztwTftS3MS05ZV7Dkl8Wl6nzFaXehKeGOmi5eObsL0fOmu0eEXf ccamWC6HSYL70Gy56l7SrLVKVU/mKsSoUY+boObneW6QAU5SdrjaF5hiRSysBDfh Q== X-Virus-Scanned: by MailRoute Received: from 004.mia.mailroute.net ([127.0.0.1]) by localhost (004.mia [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id qoXfzI_X8sXN; Thu, 17 Jul 2025 20:59:07 +0000 (UTC) Received: from bvanassche.mtv.corp.google.com (unknown [104.135.204.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 004.mia.mailroute.net (Postfix) with ESMTPSA id 4bjldy3p9lzm0yTN; Thu, 17 Jul 2025 20:59:01 +0000 (UTC) From: Bart Van Assche To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, Christoph Hellwig , Damien Le Moal , Bart Van Assche , "Martin K. Petersen" , Ming Lei Subject: [PATCH v21 08/12] scsi: core: Retry unaligned zoned writes Date: Thu, 17 Jul 2025 13:58:04 -0700 Message-ID: <20250717205808.3292926-9-bvanassche@acm.org> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog In-Reply-To: <20250717205808.3292926-1-bvanassche@acm.org> References: <20250717205808.3292926-1-bvanassche@acm.org> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable If zoned writes (REQ_OP_WRITE) for a sequential write required zone have a starting LBA that differs from the write pointer, e.g. because a prior write triggered a unit attention condition, then the storage device will respond with an UNALIGNED WRITE COMMAND error. Retry commands that failed with an unaligned write error. Reviewed-by: Damien Le Moal Cc: Martin K. Petersen Cc: Christoph Hellwig Cc: Ming Lei Signed-off-by: Bart Van Assche --- drivers/scsi/scsi_error.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index 746ff6a1f309..0af0ce8c9ed0 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -713,6 +713,22 @@ enum scsi_disposition scsi_check_sense(struct scsi_c= mnd *scmd) fallthrough; =20 case ILLEGAL_REQUEST: + /* + * Unaligned write command. This may indicate that zoned writes + * have been received by the device in the wrong order. If write + * pipelining is enabled, retry. + */ + if (sshdr.asc =3D=3D 0x21 && sshdr.ascq =3D=3D 0x04 && + req->q->limits.features & BLK_FEAT_ORDERED_HWQ && + blk_rq_is_seq_zoned_write(req) && + scsi_cmd_retry_allowed(scmd)) { + SCSI_LOG_ERROR_RECOVERY(1, + sdev_printk(KERN_WARNING, scmd->device, + "Retrying unaligned write at LBA %#llx.\n", + scsi_get_lba(scmd))); + return NEEDS_RETRY; + } + if (sshdr.asc =3D=3D 0x20 || /* Invalid command operation code */ sshdr.asc =3D=3D 0x21 || /* Logical block address out of range */ sshdr.asc =3D=3D 0x22 || /* Invalid function */