From: Keith Busch <kbusch@meta.com>
To: <linux-block@vger.kernel.org>, <linux-nvme@lists.infradead.org>,
<hch@lst.de>
Cc: <axboe@kernel.dk>, <leonro@nvidia.com>, Keith Busch <kbusch@kernel.org>
Subject: [PATCHv3 5/7] blk-mq-dma: move common dma start code to a helper
Date: Tue, 29 Jul 2025 07:34:40 -0700 [thread overview]
Message-ID: <20250729143442.2586575-6-kbusch@meta.com> (raw)
In-Reply-To: <20250729143442.2586575-1-kbusch@meta.com>
From: Keith Busch <kbusch@kernel.org>
In preparing for dma mapping integrity metadata, move the common dma
setup to a helper.
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
block/blk-mq-dma.c | 69 +++++++++++++++++++++++++---------------------
1 file changed, 38 insertions(+), 31 deletions(-)
diff --git a/block/blk-mq-dma.c b/block/blk-mq-dma.c
index 87c9a7bfa090d..646caa00a0485 100644
--- a/block/blk-mq-dma.c
+++ b/block/blk-mq-dma.c
@@ -113,44 +113,16 @@ static bool blk_rq_dma_map_iova(struct request *req, struct device *dma_dev,
return true;
}
-/**
- * blk_rq_dma_map_iter_start - map the first DMA segment for a request
- * @req: request to map
- * @dma_dev: device to map to
- * @state: DMA IOVA state
- * @iter: block layer DMA iterator
- *
- * Start DMA mapping @req to @dma_dev. @state and @iter are provided by the
- * caller and don't need to be initialized. @state needs to be stored for use
- * at unmap time, @iter is only needed at map time.
- *
- * Returns %false if there is no segment to map, including due to an error, or
- * %true ft it did map a segment.
- *
- * If a segment was mapped, the DMA address for it is returned in @iter.addr and
- * the length in @iter.len. If no segment was mapped the status code is
- * returned in @iter.status.
- *
- * The caller can call blk_rq_dma_map_coalesce() to check if further segments
- * need to be mapped after this, or go straight to blk_rq_dma_map_iter_next()
- * to try to map the following segments.
- */
-bool blk_rq_dma_map_iter_start(struct request *req, struct device *dma_dev,
- struct dma_iova_state *state, struct blk_dma_iter *iter)
+static bool blk_dma_map_iter_start(struct request *req, struct device *dma_dev,
+ struct dma_iova_state *state, struct blk_dma_iter *iter,
+ unsigned int total_len)
{
- unsigned int total_len = blk_rq_payload_bytes(req);
struct blk_map_iter *map_iter = &iter->iter;
map_iter->bio = req->bio;
- map_iter->iter = req->bio->bi_iter;
memset(&iter->p2pdma, 0, sizeof(iter->p2pdma));
iter->status = BLK_STS_OK;
- if (req->rq_flags & RQF_SPECIAL_PAYLOAD)
- iter->iter.bvec = &req->special_vec;
- else
- iter->iter.bvec = req->bio->bi_io_vec;
-
/*
* Grab the first segment ASAP because we'll need it to check for P2P
* transfers.
@@ -179,6 +151,41 @@ bool blk_rq_dma_map_iter_start(struct request *req, struct device *dma_dev,
return blk_rq_dma_map_iova(req, dma_dev, state, iter);
return blk_dma_map_direct(req, dma_dev, iter);
}
+
+/**
+ * blk_rq_dma_map_iter_start - map the first DMA segment for a request
+ * @req: request to map
+ * @dma_dev: device to map to
+ * @state: DMA IOVA state
+ * @iter: block layer DMA iterator
+ *
+ * Start DMA mapping @req to @dma_dev. @state and @iter are provided by the
+ * caller and don't need to be initialized. @state needs to be stored for use
+ * at unmap time, @iter is only needed at map time.
+ *
+ * Returns %false if there is no segment to map, including due to an error, or
+ * %true ft it did map a segment.
+ *
+ * If a segment was mapped, the DMA address for it is returned in @iter.addr and
+ * the length in @iter.len. If no segment was mapped the status code is
+ * returned in @iter.status.
+ *
+ * The caller can call blk_rq_dma_map_coalesce() to check if further segments
+ * need to be mapped after this, or go straight to blk_rq_dma_map_iter_next()
+ * to try to map the following segments.
+ */
+bool blk_rq_dma_map_iter_start(struct request *req, struct device *dma_dev,
+ struct dma_iova_state *state, struct blk_dma_iter *iter)
+{
+ iter->iter.iter = req->bio->bi_iter;
+ if (req->rq_flags & RQF_SPECIAL_PAYLOAD)
+ iter->iter.bvec = &req->special_vec;
+ else
+ iter->iter.bvec = req->bio->bi_io_vec;
+
+ return blk_dma_map_iter_start(req, dma_dev, state, iter,
+ blk_rq_payload_bytes(req));
+}
EXPORT_SYMBOL_GPL(blk_rq_dma_map_iter_start);
/**
--
2.47.3
next prev parent reply other threads:[~2025-07-29 14:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 14:34 [PATCHv3 0/7] blk dma iter for integrity metadata Keith Busch
2025-07-29 14:34 ` [PATCHv3 1/7] blk-mq: introduce blk_map_iter Keith Busch
2025-07-30 6:52 ` Kanchan Joshi
2025-07-30 8:18 ` Kanchan Joshi
2025-07-30 15:18 ` Keith Busch
2025-07-31 5:05 ` Kanchan Joshi
2025-07-29 14:34 ` [PATCHv3 2/7] blk-mq-dma: provide the bio_vec list being iterated Keith Busch
2025-07-29 20:55 ` Keith Busch
2025-07-30 12:15 ` Kanchan Joshi
2025-07-30 14:18 ` Keith Busch
2025-07-29 14:34 ` [PATCHv3 3/7] blk-mq-dma: require unmap caller provide p2p map type Keith Busch
2025-07-29 14:34 ` [PATCHv3 4/7] blk-mq: remove REQ_P2PDMA flag Keith Busch
2025-07-29 14:34 ` Keith Busch [this message]
2025-07-29 14:34 ` [PATCHv3 6/7] blk-mq-dma: add support for mapping integrity metadata Keith Busch
2025-07-29 14:34 ` [PATCHv3 7/7] nvme: convert metadata mapping to dma iter Keith Busch
2025-07-29 18:56 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250729143442.2586575-6-kbusch@meta.com \
--to=kbusch@meta.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox