From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9742328C85D for ; Fri, 1 Aug 2025 23:47:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.153.30 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754092078; cv=none; b=CvnG8rfuWhV+bKeYm7UQtlA75hnliijt/ebCdZOXXTA4suYgdM5id9ICuCdN6Av99H/hiRcx3Gw3QJt9aH1v4ViiweGhnMyIUlaAEylJ69azEb34QaFyPfxV9XTLi00oGDTnAUlwI1L5I4f9eJVroxq9nZ16RNS6MV6FMzi5OHg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754092078; c=relaxed/simple; bh=qqM7XP0L7nIP6eDwvhuc1u0A0DYGoKFdOJeN8XlyoZc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=O8B2k2hC4tYKXTaTOpV6xnFwHVTueEmltBlf5BF1dJ9QWmyOmKOoRLyuxtxThtMHSjO5qvm+AjNVCUeSBuhxdR24nZYGjSM5H3egGx54/aNlIYY2u+kmbjMi/iv0yFhbJvg+GGOX+AsS8XUZWDPoLajsKV/P0hLtNSonCVR0zIw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=meta.com; spf=pass smtp.mailfrom=meta.com; dkim=pass (2048-bit key) header.d=meta.com header.i=@meta.com header.b=mc+Sqfvk; arc=none smtp.client-ip=67.231.153.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=meta.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=meta.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=meta.com header.i=@meta.com header.b="mc+Sqfvk" Received: from pps.filterd (m0001303.ppops.net [127.0.0.1]) by m0001303.ppops.net (8.18.1.2/8.18.1.2) with ESMTP id 571MmoZg009340 for ; Fri, 1 Aug 2025 16:47:55 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=s2048-2025-q2; bh=uuy065QjwhzxX+HyBnYJHygu3ula9t7x2rGLsBYiE7k=; b=mc+SqfvkifZa zJMdym2CKp0uKTDtWynLa0wPzKbTdeGXWo5aGqGCsXWtIUHtZzOxE4sf3goyOtK4 siK1p7VyET6zvFFhLuY/TT24jjzZNrb/mhhl91E+05OsEVOh69l6GJihwH342LZy bRZXuApn70aY28AzRMvGLv00mvhKB1CNJxEM/LSn5ows+zIBLkTrn5z7Uwoo5lCc WO1tcWWcZ+YEfasZneXcVCzwN3xoBOM2ZybLiH08/iY4raxRZDjKiz2KRihOYYx7 UJCenrXI/zXrgEAbComUVMnyJGdkenlo/HZ43ku4q4KKfWFFVFEb5LVcyAMm5P5s LeNaDMS/rg== Received: from maileast.thefacebook.com ([163.114.135.16]) by m0001303.ppops.net (PPS) with ESMTPS id 488rmtwjvt-10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 01 Aug 2025 16:47:55 -0700 (PDT) Received: from twshared31684.07.ash9.facebook.com (2620:10d:c0a8:fe::f072) by mail.thefacebook.com (2620:10d:c0a9:6f::237c) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.17; Fri, 1 Aug 2025 23:47:50 +0000 Received: by devbig197.nha3.facebook.com (Postfix, from userid 544533) id BD2F83105F2; Fri, 1 Aug 2025 16:47:36 -0700 (PDT) From: Keith Busch To: , , CC: , , , , Keith Busch Subject: [PATCH 4/7] iomap: simplify direct io validity check Date: Fri, 1 Aug 2025 16:47:33 -0700 Message-ID: <20250801234736.1913170-5-kbusch@meta.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250801234736.1913170-1-kbusch@meta.com> References: <20250801234736.1913170-1-kbusch@meta.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-GUID: _i0Vr0t5ZwNscxdK4h5E6eulMNLtC6K8 X-Authority-Analysis: v=2.4 cv=Vej3PEp9 c=1 sm=1 tr=0 ts=688d522b cx=c_pps a=MfjaFnPeirRr97d5FC5oHw==:117 a=MfjaFnPeirRr97d5FC5oHw==:17 a=2OwXVqhp2XgA:10 a=VwQbUJbxAAAA:8 a=N-9tSbTDVoy7b94FiVkA:9 X-Proofpoint-ORIG-GUID: _i0Vr0t5ZwNscxdK4h5E6eulMNLtC6K8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODAxMDE5MyBTYWx0ZWRfX/ssYkEf2HbUt fE+IB5DIFrBKQv0M9KZAhTM3ZU8c1IPrdO3CcYNQd4GZwF6xDklBQdSHuMAf/HcM9ik6E+2iqI4 mLYtwDekP93IAkEVrv4Hd2j5D45teDsxY6J+4ucVtxDWETOItO7xRk+Rdcb50OZZ1Mj+vWaTDlO bWcu7prxVvxUUkKaHK7n8gt30tD0F24km/R7E4YzZyubhxL6zIJSghD/00v3ojPeT4qOgNGu3K9 cGczPuo96ymwsiXW3MKoc4eF7IsHHeMXAbvMtAhCZgDfDfpSB6MIz8/WuNYzSmIRtOFW9JMkD4j M7Tq/Do0JDXBVlZHfWWJIBEQR8mPhz3fOjkPs2ApdMP2G6wNOfm7sjOo/iNZiAuLpkYSyYUpigZ PrhFUn9xYDuzawLyRQXDrWoBdYPh+byAzmPnYLkthotwCiR66GcZalI/PC1AQrvvJagDMHDa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-01_08,2025-08-01_01,2025-03-28_01 From: Keith Busch The block layer checks all the segments for validity later, so no need for an early check. Just reduce it to a simple position and total length and defer the segment checks to the block layer. Signed-off-by: Keith Busch --- fs/iomap/direct-io.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index 6f25d4cfea9f7..2c1a45e46dc75 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -337,8 +337,7 @@ static int iomap_dio_bio_iter(struct iomap_iter *iter= , struct iomap_dio *dio) u64 copied =3D 0; size_t orig_count; =20 - if ((pos | length) & (bdev_logical_block_size(iomap->bdev) - 1) || - !bdev_iter_is_aligned(iomap->bdev, dio->submit.iter)) + if ((pos | length) & (bdev_logical_block_size(iomap->bdev) - 1)) return -EINVAL; =20 if (dio->flags & IOMAP_DIO_WRITE) { --=20 2.47.3