From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
hch@lst.de, axboe@kernel.dk, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 1/2] block: accumulate segment page gaps per bio
Date: Wed, 6 Aug 2025 16:56:21 +0200 [thread overview]
Message-ID: <20250806145621.GC20102@lst.de> (raw)
In-Reply-To: <20250805195608.2379107-1-kbusch@meta.com>
> index 0a29b20939d17..d0ed28d40fe02 100644
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -264,6 +264,8 @@ struct bio {
>
> unsigned short bi_max_vecs; /* max bvl_vecs we can hold */
>
> + unsigned int page_gaps; /* a mask of all the vector gaps */
Bloating the bio for the gaps, especially as the bio is otherwise not
built to hardware limits at all seems like an odd tradeoff.
next prev parent reply other threads:[~2025-08-06 14:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 19:56 [PATCH 1/2] block: accumulate segment page gaps per bio Keith Busch
2025-08-05 19:56 ` [PATCH 2/2] nvme: remove virtual boundary for sgl capable devices Keith Busch
2025-08-06 14:55 ` Christoph Hellwig
2025-08-06 15:04 ` Keith Busch
2025-08-05 20:32 ` [PATCH 1/2] block: accumulate segment page gaps per bio Caleb Sander Mateos
2025-08-05 20:52 ` Keith Busch
2025-08-05 22:52 ` Keith Busch
2025-08-06 14:53 ` Christoph Hellwig
2025-08-06 15:17 ` Keith Busch
2025-08-06 14:56 ` Christoph Hellwig [this message]
2025-08-06 15:44 ` Keith Busch
2025-08-10 14:31 ` Christoph Hellwig
2025-08-11 15:27 ` Keith Busch
2025-08-11 16:17 ` Christoph Hellwig
2025-08-20 19:22 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250806145621.GC20102@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox