From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0151E28F1; Mon, 25 Aug 2025 07:47:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756108070; cv=none; b=mZfGuHmBdYRxKlWCT1szXhQDzS5WGFI4UT0qKVHMjcnGYRJAOSvOkN/3mmFaPxibtlG4QL0EfXJ567pW9k9rRL83cQvwMmF7acT4bpvpYa0nR6ZmKQCb+YJ26b76E9+VmCu/tLk4UygncDCqv23VfhQz1Of098/yR/OauUsPosI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756108070; c=relaxed/simple; bh=QKU7esTWyDUdMoZwVQgLnHgWqiU0SSVuZEwfI6EgotQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HwGGxxV//Ar4eqSTFFkdSAgWAwWLW55d1I9OrPYRtFu4ECkWqYLwFrFGRhLgqaN66A/7aSu9pgyLe6Qj/TLLtL0B+zLdShsbW/IsqJJJG4DxAEAOQ5CKyLp16MoMp/tqxaCf69ThIICPqg2gbqje3NuxvNXvoH55C3voD2F8d5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 50C3968AA6; Mon, 25 Aug 2025 09:47:45 +0200 (CEST) Date: Mon, 25 Aug 2025 09:47:44 +0200 From: Christoph Hellwig To: Keith Busch Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, snitzer@kernel.org, axboe@kernel.dk, dw@davidwei.uk, brauner@kernel.org, hch@lst.de, martin.petersen@oracle.com, djwong@kernel.org, linux-xfs@vger.kernel.org, viro@zeniv.linux.org.uk, Keith Busch Subject: Re: [PATCHv3 3/8] block: align the bio after building it Message-ID: <20250825074744.GF20853@lst.de> References: <20250819164922.640964-1-kbusch@meta.com> <20250819164922.640964-4-kbusch@meta.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250819164922.640964-4-kbusch@meta.com> User-Agent: Mutt/1.5.17 (2007-11-01) Also with this we should be able to drop the iov_iter_alignment check for always COW inodes in xfs_file_dio_write. If you don't feel like doing that yourself I can add it to my todo list.