Re: [PATCH v3 12/15] iomap: make iomap_read_folio() a void return

Darrick J. Wong
2025-09-18T21:55:55Z

On Tue, Sep 16, 2025 at 04:44:22PM -0700, Joanne Koong wrote:
> No errors are propagated in iomap_read_folio(). Change
> iomap_read_folio() to a void return to make this clearer to callers.
>
> Signed-off-by: Joanne Koong <joannelkoong@gmail.com>

Yesssssss
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
> fs/iomap/buffered-io.c | 9 +--------
> include/linux/iomap.h | 2 +-
> 2 files changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
> index 72258b0109ec..be535bd3aeca 100644
> --- a/fs/iomap/buffered-io.c
> +++ b/fs/iomap/buffered-io.c
> @@ -450,7 +450,7 @@ static int iomap_read_folio_iter(struct iomap_iter *iter,
> return ret;
> }
>
> -int iomap_read_folio(const struct iomap_ops *ops,
> +void iomap_read_folio(const struct iomap_ops *ops,
> struct iomap_read_folio_ctx *ctx)
> {
> struct folio *folio = ctx->cur_folio;
> @@ -477,13 +477,6 @@ int iomap_read_folio(const struct iomap_ops *ops,
>
> if (!cur_folio_owned)
> folio_unlock(folio);
> -
> - /*
> - * Just like mpage_readahead and block_read_full_folio, we always
> - * return 0 and just set the folio error flag on errors. This
> - * should be cleaned up throughout the stack eventually.
> - */
> - return 0;
> }
> EXPORT_SYMBOL_GPL(iomap_read_folio);
>
> diff --git a/include/linux/iomap.h b/include/linux/iomap.h
> index 4a168ebb40f5..fa55ec611fff 100644
> --- a/include/linux/iomap.h
> +++ b/include/linux/iomap.h
> @@ -340,7 +340,7 @@ static inline bool iomap_want_unshare_iter(const struct iomap_iter *iter)
> ssize_t iomap_file_buffered_write(struct kiocb *iocb, struct iov_iter *from,
> const struct iomap_ops *ops,
> const struct iomap_write_ops *write_ops, void *private);
> -int iomap_read_folio(const struct iomap_ops *ops,
> +void iomap_read_folio(const struct iomap_ops *ops,
> struct iomap_read_folio_ctx *ctx);
> void iomap_readahead(const struct iomap_ops *ops,
> struct iomap_read_folio_ctx *ctx);
> --
> 2.47.3
>
>