From: Tamir Duberstein <tamird@gmail.com>
To: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Russ Weight" <russ.weight@linux.dev>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>, "Will Deacon" <will@kernel.org>,
"Waiman Long" <longman@redhat.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>,
"Christian Brauner" <brauner@kernel.org>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Jan Kara" <jack@suse.cz>, "Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Carlos Llamas" <cmllamas@google.com>,
"Suren Baghdasaryan" <surenb@google.com>,
"Jens Axboe" <axboe@kernel.dk>,
"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
"Uladzislau Rezki" <urezki@gmail.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org, linux-pci@vger.kernel.org,
Tamir Duberstein <tamird@gmail.com>
Subject: [PATCH v17 04/11] rust_binder: use `core::ffi::CStr` method names
Date: Wed, 15 Oct 2025 15:24:34 -0400 [thread overview]
Message-ID: <20251015-cstr-core-v17-4-dc5e7aec870d@gmail.com> (raw)
In-Reply-To: <20251015-cstr-core-v17-0-dc5e7aec870d@gmail.com>
Prepare for `core::ffi::CStr` taking the place of `kernel::str::CStr` by
avoiding methods that only exist on the latter.
This backslid in commit eafedbc7c050 ("rust_binder: add Rust Binder
driver").
Signed-off-by: Tamir Duberstein <tamird@gmail.com>
---
drivers/android/binder/stats.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/android/binder/stats.rs b/drivers/android/binder/stats.rs
index a83ec111d2cb..10c43679d5c3 100644
--- a/drivers/android/binder/stats.rs
+++ b/drivers/android/binder/stats.rs
@@ -72,7 +72,7 @@ pub(super) fn command_string(i: usize) -> &'static str {
// SAFETY: Accessing `binder_command_strings` is always safe.
let c_str_ptr = unsafe { binder_command_strings[i] };
// SAFETY: The `binder_command_strings` array only contains nul-terminated strings.
- let bytes = unsafe { CStr::from_char_ptr(c_str_ptr) }.as_bytes();
+ let bytes = unsafe { CStr::from_char_ptr(c_str_ptr) }.to_bytes();
// SAFETY: The `binder_command_strings` array only contains strings with ascii-chars.
unsafe { from_utf8_unchecked(bytes) }
}
@@ -81,7 +81,7 @@ pub(super) fn return_string(i: usize) -> &'static str {
// SAFETY: Accessing `binder_return_strings` is always safe.
let c_str_ptr = unsafe { binder_return_strings[i] };
// SAFETY: The `binder_command_strings` array only contains nul-terminated strings.
- let bytes = unsafe { CStr::from_char_ptr(c_str_ptr) }.as_bytes();
+ let bytes = unsafe { CStr::from_char_ptr(c_str_ptr) }.to_bytes();
// SAFETY: The `binder_command_strings` array only contains strings with ascii-chars.
unsafe { from_utf8_unchecked(bytes) }
}
--
2.51.0
next prev parent reply other threads:[~2025-10-15 19:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 19:24 [PATCH v17 00/11] rust: replace kernel::str::CStr w/ core::ffi::CStr Tamir Duberstein
2025-10-15 19:24 ` [PATCH v17 01/11] samples: rust: platform: remove trailing commas Tamir Duberstein
2025-10-15 19:24 ` [PATCH v17 02/11] rust_binder: remove trailing comma Tamir Duberstein
2025-10-15 19:30 ` Alice Ryhl
2025-10-15 19:24 ` [PATCH v17 03/11] rust_binder: use `kernel::fmt` Tamir Duberstein
2025-10-15 19:31 ` Alice Ryhl
2025-10-15 19:24 ` Tamir Duberstein [this message]
2025-10-15 19:31 ` [PATCH v17 04/11] rust_binder: use `core::ffi::CStr` method names Alice Ryhl
2025-10-15 19:24 ` [PATCH v17 05/11] rnull: use `kernel::fmt` Tamir Duberstein
2025-10-16 8:42 ` Andreas Hindborg
2025-10-15 19:24 ` [PATCH v17 06/11] rust: alloc: " Tamir Duberstein
2025-10-15 19:29 ` Tamir Duberstein
2025-10-15 19:31 ` Alice Ryhl
2025-10-15 19:47 ` Danilo Krummrich
2025-10-15 19:24 ` [PATCH v17 07/11] rust: debugfs: " Tamir Duberstein
2025-10-15 19:39 ` Matthew Maurer
2025-10-15 19:45 ` Danilo Krummrich
2025-10-15 19:24 ` [PATCH v17 08/11] rust: pci: " Tamir Duberstein
2025-10-15 19:46 ` Danilo Krummrich
2025-10-15 19:24 ` [PATCH v17 09/11] rust: remove spurious `use core::fmt::Debug` Tamir Duberstein
2025-10-15 19:33 ` Alice Ryhl
2025-10-15 19:24 ` [PATCH v17 10/11] rust: support formatting of foreign types Tamir Duberstein
2025-10-15 19:24 ` [PATCH v17 11/11] rust: replace `CStr` with `core::ffi::CStr` Tamir Duberstein
2025-10-18 17:02 ` [PATCH v17 00/11] rust: replace kernel::str::CStr w/ core::ffi::CStr Alice Ryhl
2025-10-18 17:09 ` Alice Ryhl
2025-10-20 12:00 ` Tamir Duberstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251015-cstr-core-v17-4-dc5e7aec870d@gmail.com \
--to=tamird@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=arve@android.com \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=brauner@kernel.org \
--cc=cmllamas@google.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=joelagnelf@nvidia.com \
--cc=justinstitt@google.com \
--cc=kwilczynski@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=longman@redhat.com \
--cc=lorenzo.stoakes@oracle.com \
--cc=lossin@kernel.org \
--cc=maco@android.com \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=russ.weight@linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=surenb@google.com \
--cc=tkjos@android.com \
--cc=tmgross@umich.edu \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).