From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 92B16187332; Thu, 16 Oct 2025 00:46:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=166.125.252.92 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760575613; cv=none; b=pcwaAx+ut2Buh4diMqq3rGFSzPHcC3uE93vIYntrh5MImwbW+o5ZB+bCLSZ26qjwQmw/B8N/OsZx0soQsBA2mPzai2kz4uNrsw46lJBaH68QFa8QQWbmz6wu2VOHo9TD4kEW0XKCtU9Uzmt65Ptv56OSjw8oxobdweQAeK24rHo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760575613; c=relaxed/simple; bh=bOKJ6TkZJV7OT6XeerMfxJtiPz1ZRcgBwgHMoF0YAxo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t+/mwXNGdZ9yl1vvpgnKkvNmM82jQi0Uy7CaQU05urpe+nChaPueD3HfWLiIri/y6SL73nR8s8Iy6EVxUIsuCkqjds/HjKedi4UoilrL7cZskS6ZODwvnNfyv6A006gNEHCGDi00MhMi8oeCGaNIkrVfgJEoe/OlR6ok7vsGEug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sk.com; spf=pass smtp.mailfrom=sk.com; arc=none smtp.client-ip=166.125.252.92 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sk.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sk.com X-AuditID: a67dfc5b-c2dff70000001609-3a-68f040753fb9 Date: Thu, 16 Oct 2025 09:46:40 +0900 From: Byungchul Park To: Arnd Bergmann Cc: Mathieu Desnoyers , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, kernel_team@skhynix.com, Linus Torvalds , Damien Le Moal , linux-ide@vger.kernel.org, Andreas Dilger , linux-ext4@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Will Deacon , Thomas Gleixner , Steven Rostedt , Joel Fernandes , Sasha Levin , Daniel Vetter , duyuyang@gmail.com, Johannes Berg , Tejun Heo , Theodore Ts'o , Matthew Wilcox , Dave Chinner , Amir Goldstein , kernel-team@lge.com, linux-mm@kvack.org, Andrew Morton , Michal Hocko , Minchan Kim , Johannes Weiner , vdavydov.dev@gmail.com, SeongJae Park , jglisse@redhat.com, Dennis Zhou , Christoph Lameter , Pekka Enberg , David Rientjes , Vlastimil Babka , ngupta@vflare.org, linux-block@vger.kernel.org, Josef Bacik , linux-fsdevel@vger.kernel.org, Jan Kara , Jeff Layton , Dan Williams , Christoph Hellwig , "Darrick J. Wong" , dri-devel@lists.freedesktop.org, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com, harry.yoo@oracle.com, chris.p.wilson@intel.com, Gwan-gyeong Mun , max.byungchul.park@gmail.com, Boqun Feng , Waiman Long , yunseong.kim@ericsson.com, ysk@kzalloc.com, Yeoreum Yun , Netdev , Matthew Brost , her0gyugyu@gmail.com, Jonathan Corbet , Catalin Marinas , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andy Lutomirski , Sumit Semwal , gustavo@padovan.org, Christian =?iso-8859-1?Q?K=F6nig?= , Andi Shyti , Lorenzo Stoakes , "Liam R. Howlett" , Mike Rapoport , Suren Baghdasaryan , Luis Chamberlain , Petr Pavlu , da.gomez@kernel.org, Sami Tolvanen , "Paul E. McKenney" , Frederic Weisbecker , neeraj.upadhyay@kernel.org, joelagnelf@nvidia.com, Josh Triplett , "Uladzislau Rezki (Sony)" , Lai Jiangshan , qiang.zhang@linux.dev, Juri Lelli , Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Mel Gorman , Valentin Schneider , Chuck Lever , neil@brown.name, okorniev@redhat.com, Dai Ngo , Tom Talpey , trondmy@kernel.org, Anna Schumaker , Kees Cook , Sebastian Andrzej Siewior , Clark Williams , Mark Rutland , ada.coupriediaz@arm.com, kristina.martsenko@arm.com, Kefeng Wang , Mark Brown , Kevin Brodsky , David Woodhouse , Shakeel Butt , Alexei Starovoitov , Zi Yan , Yu Zhao , Baolin Wang , usamaarif642@gmail.com, joel.granados@kernel.org, Wei Yang , Geert Uytterhoeven , tim.c.chen@linux.intel.com, linux , Alexander Shishkin , lillian@star-ark.net, Huacai Chen , francesco@valla.it, guoweikang.kernel@gmail.com, link@vivo.com, Josh Poimboeuf , Masahiro Yamada , Christian Brauner , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Oleg Nesterov , Mateusz Guzik , Andrii Nakryiko , wangfushuai@baidu.com, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, linux-i2c@vger.kernel.org, Linux-Arch , linux-modules@vger.kernel.org, rcu , linux-nfs@vger.kernel.org, linux-rt-devel@lists.linux.dev Subject: Re: [PATCH v17 01/47] llist: move llist_{head,node} definition to types.h Message-ID: <20251016004640.GB2948@system.software.com> References: <20251002081247.51255-1-byungchul@sk.com> <20251002081247.51255-2-byungchul@sk.com> <2025100230-grafted-alias-22a2@gregkh> <63034035-03e4-4184-afce-7e1a897a90e9@efficios.com> <3bbe14af-ccdc-4c78-a7ca-d4ed39fa6b5d@app.fastmail.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3bbe14af-ccdc-4c78-a7ca-d4ed39fa6b5d@app.fastmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUybZRSG87wfT18aal7rFh5BY6wSCTh0ZgnHxRh+qHtjJCG6ZAkz0WZU 21DK1jI+/Ih12UeFJmK1TFqCXWEdoR1j7dgGWyNjUGQ4LWUbRdtZpMLIWmsIXTNYmZS5uH9X 7vucK+fH4WipDedyKk2tQquRq2VYzIjj2fYtdaX/KF+e6cqB5LKBgfZTLgwGdxsL/l4ngtSq lYa0ySeC+14fgtZJEw2uM19ScPvyEgLzbBRDwmFEYJm3iiD+xwUW7ocXKJi+E0PgiK5REB06 giDdWgU/2D0YVq/+SsNRsx/Brb71/IzvJgJv9wEMf7X00zAVfQyuJRMYxs3NGOKT7RT83YfB dsDLwkBkUAShVhMFTncZTLTYKTi6iMF88gIFP3eGGHDo88F6dYqFe7NbwedcEEH4azMD5/QR EbhnRhEsX5ulwGWcp8EwmGTAPXeDBe9vRXDscBcDbR0hDBe94wwY0ssIfOf/pGBqsB2Dsa+f Bb01xULA6Wfg1EKQggnfTwwcn56kYDYSZEsrhR7PWUo4FEhjwdXhQsLqigkJl2MJWjjoqReO T8SwsJK8joUrdiIMWMIiwebeLxwcibOCp7tQ6Ly4SAnHlpKs4O75CpcXVYhfq1SoVXUK7Uuv fyhW2m6nqb29fIPvykmsR7HsJpTFEX4bGZvz44fsCRvoDDN8PplaTjEZxvwLJBi8u5Fv4p8l 5lvzG0zz8wXkO78uw0/wO8kNZ8/GvIQvIfam0XUWc1J+BZHe2Cr7oHicjLdFmQfLhSS4tkg1 IW6d88iJNS4TZ/FvkNj1Ixv3bOafI0Nnx6iMh/A3s8iYPfTfoU+SS91BpgXxlke0lke0lv+1 NkT3IKlKU1ctV6m3FSsbNaqG4j011W60/reOz+/tPo+W/O8NI55DsmxJpDuhlLLyOl1j9TAi HC3bJCn5NKaUSirljZ8otDUfaPerFbphlMcxshzJK3fqK6X8x/JaRZVCsVehfdhSXFauHuF9 sY9kQ9PfW3tLJrd/mzfX8JbTOCFqT9U3n+4vM7xbXRxs/mbU9eqi9M3SnNRAUUFxWWizsbzq felnu+4qq57f+cuuiq78hu3P7AvvyC344nCgeaQLNEudnU8HlE7HU5GKt0VbEocC8XPlv4/U BuzvqE271yIzNZdeHJ/bIf2xtCMsY3RK+dZCWquT/wuiuOeyswMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0xTdxTH87uP37001txVjDeSLKEb6EzwtRlPlCnJJF5NYPsDddlitJGb tQLFtIqgceMZCW4TO9uGVl0HsRIKBQGRihiCo4s6ItipnVqxpvKQMhZpIVBK12LM/Ofkc76P 5PxxWFIWpleyKvVRUaNW5MqxhJJkbi1LOZb2r3J958gn8Kikh4JgoJKCC82NGCpba2gYsNsQ DAUrEcyEzCRUOCIUhHVOBgKzTxmIdDsRGAZ1JDS2lxAw1bKAYfz2GwR6rw+DcayEgknrjwhM w2YGxvp2wsRQFw0RzwgBj6f9CKy+BQJ8PacRhA058GttG4ZQ/30SjPoBBL95PSSMtkTNdudz BN31pRheVV8jweVbCn8FJzHc0Z/BMDF4gYB/WjBYSrtpuGjWISira8ZguNhKgePFDQYGx+cJ eGbQEWBrzYAh6zAF96prieh90dTVFWA2lhHRMUqAvqmLgFlrAwN/1j2jwFqcBOZ+Fw0v600M zHs3QMSSD07bCAOes3oK7BP36TQ9EmYqfqaEhrYOQqh4EMZC46VGJITmdEgIXC4jhYrq6Hrb P0kK5W3Hhcv3/FiYCz7EQve0hRLu1vLCuf4UwWHyMEL5rSfMV1u+kaRmi7mqAlGzbttBidIy HiaO2LlC590mXIz8S6pQHMtzn/FtnkoyxhSXxLsCM1SMMbeKd7tnF/V4LpHXjw4vMskNr+bP D2hjvIzL4h/ZGhbzUm4zX1vVF2UJK+PmEG/3h+i3xgf8nRof9ba8hncvjBFViI1yAn9lgY3J cdwO3v/wNI7xcu4jvqfjD6IaSU3vtU3vtU3/ty2IbEDxKnVBnkKVu2mtNkdZpFYVrj2Un9eK ok9pPTV/rhMFXDt7Ecci+RLpi/pJpYxWFGiL8noRz5LyeOnmk36lTJqtKDohavIPaI7litpe lMBS8hXS3fvEgzLuO8VRMUcUj4iady7Bxq0sRvG7iY+nBgO3nExhnnq9p+VA35Wp1Kb6oo2v p9+k7/82/dOUr8O+mj1fRpy/nEwJ9m5JXv75aM7Zpemp7r3N0sc/7BO/KPcmlzrcrw/HaQe8 icmO8/aqzKEe+3xId8a1/SfjhyP6XRldaXRC/6q9x/GrrN9P/W30J9pu3PxescuQVHJdTmmV ig1rSI1W8R8ELch0kAMAAA== X-CFilter-Loop: Reflected On Fri, Oct 03, 2025 at 01:19:33AM +0200, Arnd Bergmann wrote: > On Thu, Oct 2, 2025, at 15:53, Mathieu Desnoyers wrote: > > On 2025-10-02 04:24, Greg KH wrote: > >> On Thu, Oct 02, 2025 at 05:12:01PM +0900, Byungchul Park wrote: > >>> llist_head and llist_node can be used by some other header files. For > >>> example, dept for tracking dependencies uses llist in its header. To > >>> avoid header dependency, move them to types.h. > >> > >> If you need llist in your code, then include llist.h. Don't force all > >> types.h users to do so as there is not a dependency in types.h for > >> llist.h. > >> > >> This patch shouldn't be needed as you are hiding "header dependency" for > >> other files. > > > > I agree that moving this into a catch-all types.h is not what we should > > aim for. > > > > However, it's a good practice to move the type declarations to a > > separate header file, so code that only cares about type and not > > implementation of static inline functions can include just that. > > > > Perhaps we can move struct llist_head and struct llist_node to a new > > include/linux/llist_types.h instead ? > > We have around a dozen types of linked lists, and the most common > two of them are currently defined in linux/types.h, while the > rest of them are each defined in the same header as the inteface > definition. > > Duplicating each of those headers by splitting out the trivial > type definition doesn't quite seem right either, as we'd end > up with even more headers that have to be included indirectly > in each compilation unit. > > Maybe a shared linux/list_types.h would work, to specifically I found a way to resolve my issue, but I thought it's good idea regardless of my issue and took a quick look. However, it seems like there's an overwhelming amount of work since it might require to replace all the existing include for use of list things with the new one :-). Byungchul > contain all the list_head variants that are meant to be included > in larger structures? > > Arnd