From: Christoph Hellwig <hch@lst.de>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Jan Kara <jack@suse.cz>, Christian Brauner <brauner@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Luis Chamberlain <mcgrof@kernel.org>,
linux-block@vger.kernel.org,
Joseph Qi <joseph.qi@linux.alibaba.com>,
guanghuifeng@linux.alibaba.com, zongyong.wzy@alibaba-inc.com,
zyfjeff@linux.alibaba.com
Subject: Re: question about bd_inode hashing against device_add() // Re: [PATCH 03/11] block: call bdev_add later in device_add_disk
Date: Fri, 31 Oct 2025 10:09:25 +0100 [thread overview]
Message-ID: <20251031090925.GA9379@lst.de> (raw)
In-Reply-To: <43375218-2a80-4a7a-b8bb-465f6419b595@linux.alibaba.com>
On Fri, Oct 31, 2025 at 03:46:02PM +0800, Gao Xiang wrote:
> From my understanding, before this commit, bdev_add() will
> be called prior to device_add() so insert_inode_hash()
> in bdev_add() will be called before users can see blkdev
> in the devtmpfs.
>
> But after this change, blkdev can be seen before
> insert_inode_hash(), which opens a race (although I'm not
> sure if it's an expected behavior) blkdev_get_no_open() will
> find nothing (e.g. mounting) even blkdev in devtmpfs is
> there.
We're not supposed to see the uevent notification before the
block device is ready. Do you see that earlier, or do you have
code busy polling for a node?
next prev parent reply other threads:[~2025-10-31 9:09 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 14:45 add error handling to add_disk / device_add_disk Christoph Hellwig
2021-08-18 14:45 ` [PATCH 01/11] block: add a sanity check for a live disk in del_gendisk Christoph Hellwig
2021-08-19 10:41 ` Hannes Reinecke
2021-08-18 14:45 ` [PATCH 02/11] block: fold register_disk into device_add_disk Christoph Hellwig
2021-08-19 10:48 ` Hannes Reinecke
2021-08-18 14:45 ` [PATCH 03/11] block: call bdev_add later in device_add_disk Christoph Hellwig
2021-08-20 6:06 ` Hannes Reinecke
2025-10-31 7:46 ` question about bd_inode hashing against device_add() // " Gao Xiang
2025-10-31 9:09 ` Christoph Hellwig [this message]
2025-10-31 9:36 ` Gao Xiang
2025-10-31 9:45 ` Christoph Hellwig
2025-10-31 9:54 ` Gao Xiang
2025-10-31 9:58 ` Greg Kroah-Hartman
2025-10-31 10:12 ` Gao Xiang
2025-10-31 12:23 ` Gao Xiang
2025-10-31 12:25 ` Gao Xiang
2025-10-31 14:34 ` Greg Kroah-Hartman
2025-10-31 14:44 ` Gao Xiang
2025-11-05 3:04 ` Gao Xiang
2025-11-05 12:30 ` Christian Brauner
2025-11-05 14:13 ` Gao Xiang
2025-10-31 14:31 ` Greg Kroah-Hartman
2025-10-31 14:40 ` Gao Xiang
2021-08-18 14:45 ` [PATCH 04/11] block: create the bdi link earlier " Christoph Hellwig
2021-08-20 6:08 ` Hannes Reinecke
2021-08-18 14:45 ` [PATCH 05/11] block: call blk_integrity_add " Christoph Hellwig
2021-08-20 6:08 ` Hannes Reinecke
2021-08-18 14:45 ` [PATCH 06/11] block: call blk_register_queue " Christoph Hellwig
2021-08-20 6:09 ` Hannes Reinecke
2021-08-18 14:45 ` [PATCH 07/11] block: return errors from blk_integrity_add Christoph Hellwig
2021-08-20 6:10 ` Hannes Reinecke
2021-08-18 14:45 ` [PATCH 08/11] block: return errors from disk_alloc_events Christoph Hellwig
2021-08-20 6:10 ` Hannes Reinecke
2021-08-18 14:45 ` [PATCH 09/11] block: add error handling for device_add_disk / add_disk Christoph Hellwig
2021-08-20 6:12 ` Hannes Reinecke
2021-08-18 14:45 ` [PATCH 10/11] virtio_blk: add error handling support for add_disk() Christoph Hellwig
2021-08-20 6:12 ` Hannes Reinecke
2021-08-18 14:45 ` [PATCH 11/11] null_blk: " Christoph Hellwig
2021-08-20 6:13 ` Hannes Reinecke
2021-08-23 18:57 ` add error handling to add_disk / device_add_disk Jens Axboe
2021-08-23 19:44 ` Luis Chamberlain
2021-08-23 19:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251031090925.GA9379@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=guanghuifeng@linux.alibaba.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=jack@suse.cz \
--cc=jasowang@redhat.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=mst@redhat.com \
--cc=zongyong.wzy@alibaba-inc.com \
--cc=zyfjeff@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox