From: hch <hch@lst.de>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: hch <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH 2/2] block: make bio auto-integrity deadlock safe
Date: Mon, 3 Nov 2025 14:49:21 +0100 [thread overview]
Message-ID: <20251103134921.GA25361@lst.de> (raw)
In-Reply-To: <8c8b5f23-b257-47c0-893e-2a5bde51915d@wdc.com>
On Mon, Nov 03, 2025 at 01:47:34PM +0000, Johannes Thumshirn wrote:
> >> Why can't we clear the flags when assigning gfp, or at least outside of
> >> kmalloc()s parameter list?
> > We could, but what's the point?
>
> From a reader pov it's kind of annoying to it touched twice like this,
> but I guess that's just my personal style preference here.
Note that the manipulations should eventually disappear in a common
mm-level helper as in v1. I'm just deferring this to get the fix in
without a cross-subsystem dependency that causes discussion on the
detailed approach.
next prev parent reply other threads:[~2025-11-03 13:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 10:16 make block layer auto-PI deadlock safe v3 Christoph Hellwig
2025-11-03 10:16 ` [PATCH 1/2] block: blocking mempool_alloc doesn't fail Christoph Hellwig
2025-11-03 11:16 ` Kanchan Joshi
2025-11-03 11:26 ` John Garry
2025-11-03 11:52 ` Christoph Hellwig
2025-11-03 13:20 ` Anuj gupta
2025-11-03 13:28 ` Johannes Thumshirn
2025-11-03 10:16 ` [PATCH 2/2] block: make bio auto-integrity deadlock safe Christoph Hellwig
2025-11-03 11:15 ` Kanchan Joshi
2025-11-03 13:20 ` Anuj gupta
2025-11-03 13:40 ` Johannes Thumshirn
2025-11-03 13:45 ` hch
2025-11-03 13:47 ` Johannes Thumshirn
2025-11-03 13:49 ` hch [this message]
2025-11-04 19:47 ` make block layer auto-PI deadlock safe v3 Jens Axboe
2025-11-05 13:23 ` Christoph Hellwig
2025-11-05 15:03 ` Jens Axboe
2025-11-05 19:46 ` Christoph Hellwig
2025-11-05 19:48 ` Jens Axboe
2025-11-05 15:06 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2025-10-30 14:44 make block layer auto-PI deadlock safe v2 Christoph Hellwig
2025-10-30 14:44 ` [PATCH 2/2] block: make bio auto-integrity deadlock safe Christoph Hellwig
2025-11-03 3:24 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251103134921.GA25361@lst.de \
--to=hch@lst.de \
--cc=Johannes.Thumshirn@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox