Re: [PATCH v4 4/5] xfs: check the return value of sb_min_blocksize() in xfs_fs_fill_super

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, Nov 04, 2025 at 12:36:17AM +0800, Yongpeng Yang wrote:
> From: Yongpeng Yang <yangyongpeng@xiaomi.com>
> 
> sb_min_blocksize() may return 0. Check its return value to avoid the
> filesystem super block when sb->s_blocksize is 0.
> 
> Cc: <stable@vger.kernel.org> # v6.15
> Fixes: a64e5a596067bd ("bdev: add back PAGE_SIZE block size validation
> for sb_set_blocksize()")

Odd line wrapping, does this actually work with $stablemaintainer
scripts?

> Signed-off-by: Yongpeng Yang <yangyongpeng@xiaomi.com>

Otherwise looks fine to me
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_super.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 1067ebb3b001..bc71aa9dcee8 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1693,7 +1693,10 @@ xfs_fs_fill_super(
>  	if (error)
>  		return error;
>  
> -	sb_min_blocksize(sb, BBSIZE);
> +	if (!sb_min_blocksize(sb, BBSIZE)) {
> +		xfs_err(mp, "unable to set blocksize");
> +		return -EINVAL;
> +	}
>  	sb->s_xattr = xfs_xattr_handlers;
>  	sb->s_export_op = &xfs_export_operations;
>  #ifdef CONFIG_XFS_QUOTA
> -- 
> 2.43.0
> 
>