From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>,
linux-block@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Hannes Reinecke <hare@suse.de>,
Chaitanya Kulkarni <kch@nvidia.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] block: Unexport blkdev_get_zone_info()
Date: Wed, 5 Nov 2025 20:51:46 +0100 [thread overview]
Message-ID: <20251105195146.GA5998@lst.de> (raw)
In-Reply-To: <f7bbb2a2-8342-4fd0-b906-7be5f5e59721@kernel.dk>
On Wed, Nov 05, 2025 at 12:50:30PM -0700, Jens Axboe wrote:
> On 11/5/25 12:47 PM, Christoph Hellwig wrote:
> > On Wed, Nov 05, 2025 at 11:35:53AM -0800, Bart Van Assche wrote:
> >> Unexport blkdev_get_zone_info() because it has no callers outside the
> >> block layer.
> >
> > The commit log for that clearly states we're going to add them,
> > but it'll wait a merge window to avoid cross-tree dependencies.
> >
> > I actually have the xfs changes ready right now, I can push them out
> > if you care about the glory details.
>
> That's fair, I'll just drop it then if there are planned additions.
> Would've been better to add without the export, but then that'd be
> a bit of a mess if multiple folks are going to start to use it and then
> all need the export patch.
I had that some discussion with Damien. If you want to merge the patch
that's fine, let's just hope we don't have more than one file system
wanting to use it next merge window (I think it would make sense for btrfs
too)
next prev parent reply other threads:[~2025-11-05 19:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 19:35 [PATCH] block: Unexport blkdev_get_zone_info() Bart Van Assche
2025-11-05 19:45 ` Jens Axboe
2025-11-05 19:47 ` Christoph Hellwig
2025-11-05 19:50 ` Jens Axboe
2025-11-05 19:51 ` Christoph Hellwig [this message]
2025-11-05 19:56 ` Jens Axboe
2025-11-06 12:08 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251105195146.GA5998@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=johannes.thumshirn@wdc.com \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox