[PATCH] block: Unexport blkdev_get_zone_info()

[PATCH] block: Unexport blkdev_get_zone_info()

[Bart Van Assche]

Unexport blkdev_get_zone_info() because it has no callers outside the
block layer.

Fixes: f2284eec5053 ("block: introduce blkdev_get_zone_info()")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 block/blk-zoned.c      | 3 +--
 include/linux/blkdev.h | 3 ---
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index bba64b427082..e3972db4bd66 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -914,7 +914,7 @@ static int blkdev_report_zone_fallback(struct block_device *bdev,
  *
  *    Returns 0 on success and a negative error code on failure.
  */
-int blkdev_get_zone_info(struct block_device *bdev, sector_t sector,
+static int blkdev_get_zone_info(struct block_device *bdev, sector_t sector,
 			 struct blk_zone *zone)
 {
 	struct gendisk *disk = bdev->bd_disk;
@@ -1001,7 +1001,6 @@ int blkdev_get_zone_info(struct block_device *bdev, sector_t sector,
 
 	return 0;
 }
-EXPORT_SYMBOL_GPL(blkdev_get_zone_info);
 
 /**
  * blkdev_report_zones_cached - Get cached zones information
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index f0ab02e0a673..7884f86e172f 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -436,9 +436,6 @@ typedef int (*report_zones_cb)(struct blk_zone *zone, unsigned int idx,
 int disk_report_zone(struct gendisk *disk, struct blk_zone *zone,
 		     unsigned int idx, struct blk_report_zones_args *args);
 
-int blkdev_get_zone_info(struct block_device *bdev, sector_t sector,
-			 struct blk_zone *zone);
-
 #define BLK_ALL_ZONES  ((unsigned int)-1)
 int blkdev_report_zones(struct block_device *bdev, sector_t sector,
 		unsigned int nr_zones, report_zones_cb cb, void *data);

Re: [PATCH] block: Unexport blkdev_get_zone_info()

[Jens Axboe]

On Wed, 05 Nov 2025 11:35:53 -0800, Bart Van Assche wrote:
> Unexport blkdev_get_zone_info() because it has no callers outside the
> block layer.
> 
> 

Applied, thanks!

[1/1] block: Unexport blkdev_get_zone_info()
      commit: a6c78e2f9317bed8d3d00fce2188aaace6e948c2

Best regards,
-- 
Jens Axboe

Re: [PATCH] block: Unexport blkdev_get_zone_info()

[Christoph Hellwig]

On Wed, Nov 05, 2025 at 11:35:53AM -0800, Bart Van Assche wrote:
> Unexport blkdev_get_zone_info() because it has no callers outside the
> block layer.

The commit log for that clearly states we're going to add them,
but it'll wait a merge window to avoid cross-tree dependencies.

I actually have the xfs changes ready right now, I can push them out
if you care about the glory details.

Re: [PATCH] block: Unexport blkdev_get_zone_info()

[Jens Axboe]

On 11/5/25 12:47 PM, Christoph Hellwig wrote:
> On Wed, Nov 05, 2025 at 11:35:53AM -0800, Bart Van Assche wrote:
>> Unexport blkdev_get_zone_info() because it has no callers outside the
>> block layer.
> 
> The commit log for that clearly states we're going to add them,
> but it'll wait a merge window to avoid cross-tree dependencies.
> 
> I actually have the xfs changes ready right now, I can push them out
> if you care about the glory details.

That's fair, I'll just drop it then if there are planned additions.
Would've been better to add without the export, but then that'd be
a bit of a mess if multiple folks are going to start to use it and then
all need the export patch.

-- 
Jens Axboe

Re: [PATCH] block: Unexport blkdev_get_zone_info()

[Christoph Hellwig]

On Wed, Nov 05, 2025 at 12:50:30PM -0700, Jens Axboe wrote:
> On 11/5/25 12:47 PM, Christoph Hellwig wrote:
> > On Wed, Nov 05, 2025 at 11:35:53AM -0800, Bart Van Assche wrote:
> >> Unexport blkdev_get_zone_info() because it has no callers outside the
> >> block layer.
> > 
> > The commit log for that clearly states we're going to add them,
> > but it'll wait a merge window to avoid cross-tree dependencies.
> > 
> > I actually have the xfs changes ready right now, I can push them out
> > if you care about the glory details.
> 
> That's fair, I'll just drop it then if there are planned additions.
> Would've been better to add without the export, but then that'd be
> a bit of a mess if multiple folks are going to start to use it and then
> all need the export patch.

I had that some discussion with Damien.  If you want to merge the patch
that's fine, let's just hope we don't have more than one file system
wanting to use it next merge window (I think it would make sense for btrfs
too)

Re: [PATCH] block: Unexport blkdev_get_zone_info()

[Jens Axboe]

On 11/5/25 12:51 PM, Christoph Hellwig wrote:
> On Wed, Nov 05, 2025 at 12:50:30PM -0700, Jens Axboe wrote:
>> On 11/5/25 12:47 PM, Christoph Hellwig wrote:
>>> On Wed, Nov 05, 2025 at 11:35:53AM -0800, Bart Van Assche wrote:
>>>> Unexport blkdev_get_zone_info() because it has no callers outside the
>>>> block layer.
>>>
>>> The commit log for that clearly states we're going to add them,
>>> but it'll wait a merge window to avoid cross-tree dependencies.
>>>
>>> I actually have the xfs changes ready right now, I can push them out
>>> if you care about the glory details.
>>
>> That's fair, I'll just drop it then if there are planned additions.
>> Would've been better to add without the export, but then that'd be
>> a bit of a mess if multiple folks are going to start to use it and then
>> all need the export patch.
> 
> I had that some discussion with Damien.  If you want to merge the patch
> that's fine, let's just hope we don't have more than one file system
> wanting to use it next merge window (I think it would make sense for btrfs
> too)

Let's just defer if there are planned users for 6.19. Once we're in
the middle of that release and if no users have been added, then we
can kill it.

-- 
Jens Axboe

Re: [PATCH] block: Unexport blkdev_get_zone_info()

[Christoph Hellwig]

On Wed, Nov 05, 2025 at 12:56:49PM -0700, Jens Axboe wrote:
> Let's just defer if there are planned users for 6.19. Once we're in
> the middle of that release and if no users have been added, then we
> can kill it.

Yes, if the users don't materialize in the next merge window this should
absolutely go away.