[PATCH 3/2] block: don't return 1 for the fallback case in blkdev_get_zone_info

[PATCH 3/2] block: don't return 1 for the fallback case in blkdev_get_zone_info

[Christoph Hellwig]

blkdev_do_report_zones returns the number of reported zones, but
blkdev_get_zone_info returns 0 or an errno.  Translate to the expected
return value in blkdev_report_zone_fallback.

Fixes: b037d41762fd ("block: introduce blkdev_get_zone_info()")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-zoned.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index c5226bcaaa94..8204214e3b89 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -895,8 +895,14 @@ static int blkdev_report_zone_fallback(struct block_device *bdev,
 		.data = zone,
 		.report_active = true,
 	};
+	int error;
 
-	return blkdev_do_report_zones(bdev, sector, 1, &args);
+	error = blkdev_do_report_zones(bdev, sector, 1, &args);
+	if (error < 0)
+		return error;
+	if (error == 0)
+		return -EIO;
+	return 0;
 }
 
 /*
-- 
2.47.3

Re: [PATCH 3/2] block: don't return 1 for the fallback case in blkdev_get_zone_info

[Damien Le Moal]

On 11/6/25 23:53, Christoph Hellwig wrote:
> blkdev_do_report_zones returns the number of reported zones, but
> blkdev_get_zone_info returns 0 or an errno.  Translate to the expected
> return value in blkdev_report_zone_fallback.
> 
> Fixes: b037d41762fd ("block: introduce blkdev_get_zone_info()")
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Doh! Of course...

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

Note: Is this patch alone or part of a series ? (the subject has the odd 3/2...)


-- 
Damien Le Moal
Western Digital Research

Re: [PATCH 3/2] block: don't return 1 for the fallback case in blkdev_get_zone_info

[Christoph Hellwig]

On Fri, Nov 07, 2025 at 03:14:20PM +0900, Damien Le Moal wrote:
> Note: Is this patch alone or part of a series ?
> (the subject has the odd 3/2...)

Yeah, this was supposed to be a follow up to the report zones caching
fixes, but I edited out the in-reply-to header accidentally.

Re: [PATCH 3/2] block: don't return 1 for the fallback case in blkdev_get_zone_info

[Jens Axboe]

On Thu, 06 Nov 2025 15:53:32 +0100, Christoph Hellwig wrote:
> blkdev_do_report_zones returns the number of reported zones, but
> blkdev_get_zone_info returns 0 or an errno.  Translate to the expected
> return value in blkdev_report_zone_fallback.
> 
> 

Applied, thanks!

[3/3] block: don't return 1 for the fallback case in blkdev_get_zone_info
      commit: 86a9ce21f5b781c56eba23cbbd2264ab74778ab0

Best regards,
-- 
Jens Axboe