From: Eric Biggers <ebiggers@kernel.org>
To: Keith Busch <kbusch@meta.com>
Cc: linux-block@vger.kernel.org, hch@lst.de, axboe@kernel.dk,
Keith Busch <kbusch@kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCHv4] blk-integrity: support arbitrary buffer alignment
Date: Thu, 13 Nov 2025 09:31:35 -0800 [thread overview]
Message-ID: <20251113173135.GD1792@sol> (raw)
In-Reply-To: <20251113152621.2183637-1-kbusch@meta.com>
On Thu, Nov 13, 2025 at 07:26:21AM -0800, Keith Busch wrote:
> +static void blk_set_ip_pi(struct t10_pi_tuple *pi,
> + struct blk_integrity_iter *iter)
> {
> - u8 offset = bi->pi_offset;
> - unsigned int i;
> -
> - for (i = 0 ; i < iter->data_size ; i += iter->interval) {
> - struct crc64_pi_tuple *pi = iter->prot_buf + offset;
> + __be16 csum = (__force __be16)~(lower_16_bits(iter->crc));
This just throws away half of the checksum instead of properly combining
the two halves. How is this being tested?
> + __put_unaligned_t(__be16, csum, &pi->guard_tag);
This can just use put_unaligned().
- Eric
next prev parent reply other threads:[~2025-11-13 17:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 15:26 [PATCHv4] blk-integrity: support arbitrary buffer alignment Keith Busch
2025-11-13 17:31 ` Eric Biggers [this message]
2025-11-13 18:14 ` Keith Busch
2025-11-13 19:20 ` Eric Biggers
2025-11-13 19:48 ` Keith Busch
2025-11-13 19:55 ` Martin K. Petersen
2025-11-13 19:57 ` Keith Busch
2025-11-13 20:02 ` Eric Biggers
2025-11-13 20:11 ` Keith Busch
2025-11-13 20:21 ` Eric Biggers
2025-11-13 20:21 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251113173135.GD1792@sol \
--to=ebiggers@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox