From: Khazhismel Kumykov <khazhy@chromium.org>
To: Tejun Heo <tj@kernel.org>, Josef Bacik <josef@toxicpanda.com>,
Jens Axboe <axboe@kernel.dk>
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
Yu Kuai <yukuai@kernel.org>,
Khazhismel Kumykov <khazhy@google.com>
Subject: [PATCH v2 2/3] block/blk-throttle: drop unneeded blk_stat_enable_accounting
Date: Fri, 14 Nov 2025 15:54:33 -0800 [thread overview]
Message-ID: <20251114235434.2168072-3-khazhy@google.com> (raw)
In-Reply-To: <20251114235434.2168072-1-khazhy@google.com>
From: Guenter Roeck <linux@roeck-us.net>
After the removal of CONFIG_BLK_DEV_THROTTLING_LOW, it is no longer
necessary to enable block accounting, so remove the call to
blk_stat_enable_accounting(). With that, the track_bio_latency variable
is no longer used and can be deleted from struct throtl_data. Also,
including blk-stat.h is no longer necessary.
Fixes: bf20ab538c81 ("blk-throttle: remove CONFIG_BLK_DEV_THROTTLING_LOW")
Cc: Yu Kuai <yukuai@kernel.org>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Khazhismel Kumykov <khazhy@google.com>
---
block/blk-throttle.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/block/blk-throttle.c b/block/blk-throttle.c
index c19d052a8f2f..041bcf7b2c7c 100644
--- a/block/blk-throttle.c
+++ b/block/blk-throttle.c
@@ -12,7 +12,6 @@
#include <linux/blktrace_api.h>
#include "blk.h"
#include "blk-cgroup-rwstat.h"
-#include "blk-stat.h"
#include "blk-throttle.h"
/* Max dispatch from a group in 1 round */
@@ -43,8 +42,6 @@ struct throtl_data
/* Work for dispatching throttled bios */
struct work_struct dispatch_work;
-
- bool track_bio_latency;
};
static void throtl_pending_timer_fn(struct timer_list *t);
@@ -1340,9 +1337,6 @@ static int blk_throtl_init(struct gendisk *disk)
}
td->throtl_slice = DFL_THROTL_SLICE;
- td->track_bio_latency = !queue_is_mq(q);
- if (!td->track_bio_latency)
- blk_stat_enable_accounting(q);
out:
blk_mq_unquiesce_queue(disk->queue);
--
2.52.0.rc1.455.g30608eb744-goog
next prev parent reply other threads:[~2025-11-14 23:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 23:54 [PATCH v2 0/3] block/blk-throttle: Fix throttle slice time for SSDs Khazhismel Kumykov
2025-11-14 23:54 ` [PATCH v2 1/3] " Khazhismel Kumykov
2025-11-15 15:51 ` Yu Kuai
2025-11-14 23:54 ` Khazhismel Kumykov [this message]
2025-11-15 15:53 ` [PATCH v2 2/3] block/blk-throttle: drop unneeded blk_stat_enable_accounting Yu Kuai
2025-11-14 23:54 ` [PATCH v2 3/3] block/blk-throttle: Remove throtl_slice from struct throtl_data Khazhismel Kumykov
2025-11-15 15:56 ` Yu Kuai
2025-11-17 16:42 ` [PATCH v2 0/3] block/blk-throttle: Fix throttle slice time for SSDs Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251114235434.2168072-3-khazhy@google.com \
--to=khazhy@chromium.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=khazhy@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=tj@kernel.org \
--cc=yukuai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox