From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86F4830F541 for ; Fri, 14 Nov 2025 23:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763164492; cv=none; b=IyAzqOeYfPYV18VbGg7vWdcaDnb2puVTmytLshnsDew1z2+PCDsmHrhew5jIW626gArpjvVOBV2sBMsw39bOGrB+EICrr38HL1GEvsqBvZdK7I2/TwOIvn3s8cyy/zN99IcOQlzjd7m+SLQlVACWrli9IBwgCg+Y+LZTh+yl8SU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763164492; c=relaxed/simple; bh=3ISK3vmEmXYxkx6L/TlERdD5sr35Uw+sM1ovYwgxP0I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZQAQLacAKcdLuJUi9NYumbrK65mWIGTOQPUF9mnnRETA6tOnYNBnAfV5hgHU/x2v75NLNvtC8k2bftlUOnRygt1XGWbh8OD9sBLSW6fGuIHdoAi/I6hanI/v6lLuODRf8KqwkKBhaCO4SHs98l6emgiADFlqFyJ3ZnRyYBtd8Z8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=DS9f4io7; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="DS9f4io7" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-bbf2c3eccc9so2657539a12.0 for ; Fri, 14 Nov 2025 15:54:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1763164490; x=1763769290; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uFdmZz4q1tuXgiwvVFEfWPnDBWXiUNf2fULwgRSPSqE=; b=DS9f4io790OsIQQ1ObW/CGEvjd4Xxt1lt1eK4HNFtVr5b14K75C/8nS5J30rc6wyPD 0+X0bU9Wl7BC37ENdbc1ABMIu6bI7vHuJ2XrwdAzMcUfGKJeGhBx9RcGWeKEyIIcrFQw 9nhrtp5Lt6wdQChMsh6Ayf7vBmZzle0QYDOEc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763164490; x=1763769290; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uFdmZz4q1tuXgiwvVFEfWPnDBWXiUNf2fULwgRSPSqE=; b=vBTAzFjyT66QJ5L/YwelBskc3Rfrj0rNXUnq1EJ/52jbms2ZnI/0duZ8etb7UTCWhF uQbubD6Io6Ykd4PW3GvN7uE5+gZg7Tn5VXdFYZLDi2BbCPNQM6p2cLeOGahTqpDyzIqw lSH73fkisG6C2jsK1C1pPIWRvWQ2E2OQuSiMhwqopyd6/i2n/SWPCG/IDq+UYs+WiuIB ztLpmwtXaNLy9qJCs/r7bC039F9wCZ1hdKw7u69ji+sRAoeF+KoqxQDSg7PeHFt7jL8m rY/BkHDKO3J9e9pzX2asHwMFqH1yzM2qU68rcNad8U3zqIttMWK9Qr9eIhikW1WpzRTH mr3A== X-Forwarded-Encrypted: i=1; AJvYcCVYRswmoBWppTkdzNBXKW+cOc8yGjrK5fkgbotYsDz3YyuEGbFrb044zO4joMIyoEyRQ4vCnAKFj7uc+w==@vger.kernel.org X-Gm-Message-State: AOJu0YyiHTSjrFEiiSFftXqNkmyFwY+9asmFdfPdgbicCWZZBcEIVH62 eLbuIUvqN+s9ckeITTqM+AUSXSuZv3iZLqHcCBpSQxWFsJevaPYktP9SugORaJeZ6Q== X-Gm-Gg: ASbGncsxU3PVpA6jn8RE4Gf6PYIECcVQiE3c+CAWrE9Qufw+1GqaubDpNrlb6vJUorL 65XTUyaNWkuwD36n+2bdeQKdoZonovwPGdS99HDc6UNMAKSLMlE6+2OOc4ZhAgFWt5YJeun1NVv l7kbG8cC4uYCV5oQhY4wK5kJWRwbjof7iyAsXKu1Fu/X/fITKKvaQ5WHlzlIYd48HJyDNYgTn4B VngmJ8RWF8ulOLpn8DSlZ9O78KiORvzQla/VHJoJZUfi48suDz5RfclSj6298KB0uQG7N5fivkL O14FypKqEWp7VWJjmiZMAuxjLcUrYeU57mQcbxEsitU96H2mBjYTfrfRLNgADhsuM+Hom+7c+pa n0pUtUVremYBQ2JpImJfLVkcjyj1yK234DslFp4ERjxR8lYCxbvDw2Hxx2Iuh3KFl5yvR5Nw30/ 9CBppVGT7yFcxvn/SnZUwOSlpMh6T8y5SRkO8oVzqKhDLa11h/QLo0/uqY0qtEroOMgzUOhbCRi lxhnJAuLDOV96VJk7MR X-Google-Smtp-Source: AGHT+IHedTwgJN/jlP+lN345ODfHCK52a3qWBMDHclzPe3MK3s/H5bCWbd4lV8zbwLxOjyRjOUEI3A== X-Received: by 2002:a05:7300:f68b:b0:2a4:3593:ccc6 with SMTP id 5a478bee46e88-2a4ab443a21mr1704630eec.13.1763164489828; Fri, 14 Nov 2025 15:54:49 -0800 (PST) Received: from khazhy-linux.svl.corp.google.com ([2a00:79e0:2e5b:9:bb76:6725:868a:78e5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2a49db7a753sm14114818eec.6.2025.11.14.15.54.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 15:54:49 -0800 (PST) From: Khazhismel Kumykov X-Google-Original-From: Khazhismel Kumykov To: Tejun Heo , Josef Bacik , Jens Axboe Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck , Yu Kuai , Khazhismel Kumykov Subject: [PATCH v2 2/3] block/blk-throttle: drop unneeded blk_stat_enable_accounting Date: Fri, 14 Nov 2025 15:54:33 -0800 Message-ID: <20251114235434.2168072-3-khazhy@google.com> X-Mailer: git-send-email 2.52.0.rc1.455.g30608eb744-goog In-Reply-To: <20251114235434.2168072-1-khazhy@google.com> References: <20251114235434.2168072-1-khazhy@google.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Guenter Roeck After the removal of CONFIG_BLK_DEV_THROTTLING_LOW, it is no longer necessary to enable block accounting, so remove the call to blk_stat_enable_accounting(). With that, the track_bio_latency variable is no longer used and can be deleted from struct throtl_data. Also, including blk-stat.h is no longer necessary. Fixes: bf20ab538c81 ("blk-throttle: remove CONFIG_BLK_DEV_THROTTLING_LOW") Cc: Yu Kuai Cc: Tejun Heo Signed-off-by: Guenter Roeck Signed-off-by: Khazhismel Kumykov --- block/blk-throttle.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/block/blk-throttle.c b/block/blk-throttle.c index c19d052a8f2f..041bcf7b2c7c 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -12,7 +12,6 @@ #include #include "blk.h" #include "blk-cgroup-rwstat.h" -#include "blk-stat.h" #include "blk-throttle.h" /* Max dispatch from a group in 1 round */ @@ -43,8 +42,6 @@ struct throtl_data /* Work for dispatching throttled bios */ struct work_struct dispatch_work; - - bool track_bio_latency; }; static void throtl_pending_timer_fn(struct timer_list *t); @@ -1340,9 +1337,6 @@ static int blk_throtl_init(struct gendisk *disk) } td->throtl_slice = DFL_THROTL_SLICE; - td->track_bio_latency = !queue_is_mq(q); - if (!td->track_bio_latency) - blk_stat_enable_accounting(q); out: blk_mq_unquiesce_queue(disk->queue); -- 2.52.0.rc1.455.g30608eb744-goog