From: Leon Romanovsky <leon@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org,
Chaitanya Kulkarni <kch@nvidia.com>
Subject: Re: [PATCH v2 1/2] nvme-pci: Use size_t for length fields to handle larger sizes
Date: Wed, 19 Nov 2025 16:44:52 +0200 [thread overview]
Message-ID: <20251119144452.GI18335@unreal> (raw)
In-Reply-To: <20251119101048.GA26266@lst.de>
On Wed, Nov 19, 2025 at 11:10:48AM +0100, Christoph Hellwig wrote:
> On Wed, Nov 19, 2025 at 11:55:16AM +0200, Leon Romanovsky wrote:
> > So what is the resolution? Should I drop this patch or not?
>
> I think it should be dropped. I don't think having to use one 96-bit
> structure per 4GB worth of memory should be a deal breaker.
Christoph,
It seems like no size change will before and after my change.
https://lore.kernel.org/linux-nvme/20251117-nvme-phys-types-v2-0-c75a60a2c468@nvidia.com/T/#ma575c050517e91e7630683cf193e39d812338fa4
Thanks
next prev parent reply other threads:[~2025-11-19 14:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 19:22 [PATCH v2 0/2] block: Generalize physical entry definition Leon Romanovsky
2025-11-17 19:22 ` [PATCH v2 1/2] nvme-pci: Use size_t for length fields to handle larger sizes Leon Romanovsky
2025-11-17 19:35 ` Keith Busch
2025-11-17 20:01 ` Leon Romanovsky
2025-11-18 5:18 ` Christoph Hellwig
2025-11-18 23:10 ` Keith Busch
2025-11-18 5:03 ` Christoph Hellwig
2025-11-19 9:55 ` Leon Romanovsky
2025-11-19 10:10 ` Christoph Hellwig
2025-11-19 11:06 ` Leon Romanovsky
2025-11-19 14:44 ` Leon Romanovsky [this message]
2025-11-19 13:36 ` David Laight
2025-11-19 13:58 ` Leon Romanovsky
2025-11-19 14:13 ` David Laight
2025-11-17 19:22 ` [PATCH v2 2/2] types: move phys_vec definition to common header Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119144452.GI18335@unreal \
--to=leon@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).