Re: [PATCHv2 1/2] blktests: test direct io offsets

Keith Busch
2025-11-19T23:59:08Z

On Wed, Nov 19, 2025 at 11:48:47PM +0000, Chaitanya Kulkarni wrote:
> On 11/19/25 11:54, Keith Busch wrote:
> > + ret = pwritev(test_fd, iov, vecs, 0);
> > + if (ret < 0)
> > + err(errno, "%s: failed to read buf", __func__);
> > +
>
>
> is pwritev correct above or it should be preadv () ?

Good eye, it should have been preadv. This part is currently unreachable
though, as it requires byte-aligned dma limits and the kernel doesn't
report such a value. But if this were to run, the test would have
falsely declared data corruption.