From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B265305043 for ; Mon, 1 Dec 2025 15:09:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764601758; cv=none; b=s5LrWXVf+rGuimiuNYUweiuIRJAbu5yR4voWoO6gUadOlN8gz9OUjHyWAw7sq6q5iIOV5EghH9Xp1oyJTs5JUR/6LlSTlM+hqcLWTHhNKLPvCJuhZEr9IeltJpw0IhRPnPuHNwx9dObGZ4o2OS2fUOTUbpc4nfhshsC6nYQHizg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764601758; c=relaxed/simple; bh=1q1DMKt5ni6lCOmEvxz2w8y/feMQlJ43nlhVk82nTWA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lFv6G+3Q2msfXkbejMmLrWY4PIZ0XqzpZbXqIQEjLAzxOzWrrELZBwUwJuC+oe1n73tmzEoGSgI9piBUDqPUew1Zn6PQxMS7VVmwHzu+kYAmNjIpiXbsw/tYek3QsxD6ZORIgarY1NE6hBr5tLMoSbm7fo461h85tqUzyryqSSo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UgRYHw0I; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UgRYHw0I" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764601756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=779X9C6h5K3skYhM8d7MYfpqdYLObiQFQ6B6MrIqbsI=; b=UgRYHw0I8PVo8/QYgp+zOD6Hrh/PcukELjciWuUyvqfS5RymlxdQo8YWKIokxvaVyACX5D aS8qVsj6mlOM0eeMIsT1OToDH2AKx9oQiKEUChm30xsQX73v75DwLPRvEIVtUYaTbdOB1t OawcZdSCJockYW61IIwLyXJ/TKCgDb4= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-480-Tj_YiY8EMgWuX_4BExsQwA-1; Mon, 01 Dec 2025 10:09:14 -0500 X-MC-Unique: Tj_YiY8EMgWuX_4BExsQwA-1 X-Mimecast-MFC-AGG-ID: Tj_YiY8EMgWuX_4BExsQwA_1764601752 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1753D195609D; Mon, 1 Dec 2025 15:09:12 +0000 (UTC) Received: from localhost (unknown [10.2.16.172]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DA01C180047F; Mon, 1 Dec 2025 15:09:10 +0000 (UTC) Date: Mon, 1 Dec 2025 10:09:09 -0500 From: Stefan Hajnoczi To: Christoph Hellwig Cc: linux-block@vger.kernel.org, Keith Busch , "Martin K. Petersen" , linux-kernel@vger.kernel.org, "James E.J. Bottomley" , Mike Christie , linux-nvme@lists.infradead.org, Jens Axboe , linux-scsi@vger.kernel.org, Sagi Grimberg Subject: Re: [PATCH v2 1/4] scsi: sd: reject invalid pr_read_keys() num_keys values Message-ID: <20251201150909.GB866564@fedora> References: <20251127155424.617569-1-stefanha@redhat.com> <20251127155424.617569-2-stefanha@redhat.com> <20251201063413.GA19461@lst.de> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="i8xxr+XJ1Xv3lF4c" Content-Disposition: inline In-Reply-To: <20251201063413.GA19461@lst.de> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 --i8xxr+XJ1Xv3lF4c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 01, 2025 at 07:34:13AM +0100, Christoph Hellwig wrote: > On Thu, Nov 27, 2025 at 10:54:21AM -0500, Stefan Hajnoczi wrote: > > + /* > > + * Each reservation key takes 8 bytes and there is an 8-byte header > > + * before the reservation key list. The total size must fit into the > > + * 16-bit ALLOCATION LENGTH field. > > + */ > > + if (num_keys > (USHRT_MAX / 8) - 1) > > + return -EINVAL; > > + > > + data_len =3D num_keys * 8 + 8; >=20 > Having the same arithmerics express here in two different ways is a bit > odd. >=20 > I'd expected this to be something like: >=20 > if (check_mul_overflow(num_keys, 8, &data_len) || data_len > USHRT_MAX) > return -EINVAL; Thanks, will fix. Stefan --i8xxr+XJ1Xv3lF4c Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmktr5UACgkQnKSrs4Gr c8i6LggAuMKNzG5olHxh++csQmnmYxzq4kE3SpSVE1RXp1nBtNnhXXpkikKBmoNN AHOh/pWQAQiCaQr0PQDAfOZl5BgfVWAr+GhgL2cSfxLjakmIcJmiC9XOcYXO/iKH OA9Zz/QLeSpkyxEPXXxf0I6aoUUmc1kXRgWxWD380WSdqtU2YY+99aFagK25Q1rP io6U352p85/2oolXwu6vJry1k479CbPL+eFFyxs11PUsO1HmF7x/wNLg1h1iMkl2 JplumT2Yb6kDNrvy+YhZUaWqCqQmHfiO1o05u+sso9JwbA2Q3eHNkzQ8mCvUV8ol 8jswyhnd25j+NX9B+7etYTi57cy5Bw== =kHJb -----END PGP SIGNATURE----- --i8xxr+XJ1Xv3lF4c--