From: Christoph Hellwig <hch@lst.de>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-fscrypt@vger.kernel.org
Subject: Re: [PATCH 7/9] blk-crypto: use mempool_alloc_bulk for encrypted bio page allocation
Date: Mon, 15 Dec 2025 07:01:33 +0100 [thread overview]
Message-ID: <20251215060133.GB31097@lst.de> (raw)
In-Reply-To: <20251213012141.GE2696@quark>
On Fri, Dec 12, 2025 at 05:21:41PM -0800, Eric Biggers wrote:
> > + memset(pages, 0, sizeof(struct page *) * nr_segs);
> > + nr_allocated = alloc_pages_bulk(GFP_KERNEL, nr_segs, pages);
> > + if (nr_allocated < nr_segs)
> > + mempool_alloc_bulk(blk_crypto_bounce_page_pool, (void **)pages,
> > + nr_segs, nr_allocated);
>
> alloc_pages_bulk() is documented to fill in pages sequentially. So the
> "random pages in the array unallocated" part seems misleading. This
> also means that only the remaining portion needs to be passed to
> mempool_alloc_bulk(), similar to blk_crypto_fallback_encrypt_endio().
I the better idea is to offset the search in mempool_alloc_bulk
based on the passed in allocated argument. I'll prepare a patch for
that.
next prev parent reply other threads:[~2025-12-15 6:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 15:23 move blk-crypto-fallback to sit above the block layer v2 Christoph Hellwig
2025-12-10 15:23 ` [PATCH 1/9] fscrypt: pass a real sector_t to fscrypt_zeroout_range_inline_crypt Christoph Hellwig
2025-12-10 15:23 ` [PATCH 2/9] fscrypt: keep multiple bios in flight in fscrypt_zeroout_range_inline_crypt Christoph Hellwig
2025-12-10 15:23 ` [PATCH 3/9] block: merge bio_split_rw_at into bio_split_io_at Christoph Hellwig
2025-12-13 0:31 ` Eric Biggers
2025-12-15 6:00 ` Christoph Hellwig
2025-12-10 15:23 ` [PATCH 4/9] blk-crypto: submit the encrypted bio in blk_crypto_fallback_bio_prep Christoph Hellwig
2025-12-13 0:48 ` Eric Biggers
2025-12-10 15:23 ` [PATCH 5/9] blk-crypto: optimize bio splitting in blk_crypto_fallback_encrypt_bio Christoph Hellwig
2025-12-13 0:56 ` Eric Biggers
2025-12-10 15:23 ` [PATCH 6/9] blk-crypto: use on-stack skcipher requests for fallback en/decryption Christoph Hellwig
2025-12-13 1:00 ` Eric Biggers
2025-12-10 15:23 ` [PATCH 7/9] blk-crypto: use mempool_alloc_bulk for encrypted bio page allocation Christoph Hellwig
2025-12-13 1:21 ` Eric Biggers
2025-12-15 6:01 ` Christoph Hellwig [this message]
2025-12-10 15:23 ` [PATCH 8/9] blk-crypto: optimize data unit alignment checking Christoph Hellwig
2025-12-11 8:28 ` kernel test robot
2025-12-11 11:43 ` kernel test robot
2025-12-13 1:30 ` Eric Biggers
2025-12-15 6:02 ` Christoph Hellwig
2025-12-16 3:16 ` kernel test robot
2025-12-10 15:23 ` [PATCH 9/9] blk-crypto: handle the fallback above the block layer Christoph Hellwig
2025-12-13 1:46 ` Eric Biggers
-- strict thread matches above, loose matches on Subject: below --
2025-12-17 6:06 move blk-crypto-fallback to sit above the block layer v3 Christoph Hellwig
2025-12-17 6:06 ` [PATCH 7/9] blk-crypto: use mempool_alloc_bulk for encrypted bio page allocation Christoph Hellwig
2025-12-19 20:02 ` Eric Biggers
2025-12-19 20:25 ` Eric Biggers
2025-12-22 22:16 ` Christoph Hellwig
2025-12-22 22:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251215060133.GB31097@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=ebiggers@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).