From: Christoph Hellwig <hch@lst.de>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: initialize auto integrity buffer opaque
Date: Thu, 8 Jan 2026 14:58:21 +0100 [thread overview]
Message-ID: <20260108135821.GA8886@lst.de> (raw)
In-Reply-To: <20260108090401.1091352-1-csander@purestorage.com>
The subject sounds a little weird. From looking at the commit
message and the code change I'd expect it to be something like:
block: zero auto integrity buffer when not fully occupied by PI tuple
does that make sense?
> Switch the gfp_t variable to bool zero_buffer since it's only used to
> compute the zero_buffer argument to bio_integrity_alloc_buf().
Yeah, that also makes total sense now. But maybe split it into a
separate cleanup patch to not detract from the bug fix?
next prev parent reply other threads:[~2026-01-08 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 9:03 [PATCH] block: initialize auto integrity buffer opaque Caleb Sander Mateos
2026-01-08 13:36 ` Anuj gupta
2026-01-08 13:58 ` Christoph Hellwig [this message]
2026-01-08 16:31 ` Caleb Sander Mateos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260108135821.GA8886@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox