public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Caleb Sander Mateos <csander@purestorage.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	Anuj Gupta <anuj20.g@samsung.com>, Christoph Hellwig <hch@lst.de>,
	Caleb Sander Mateos <csander@purestorage.com>
Subject: [PATCH v2 3/3] block: use pi_tuple_size in bi_offload_capable()
Date: Thu,  8 Jan 2026 10:22:12 -0700	[thread overview]
Message-ID: <20260108172212.1402119-4-csander@purestorage.com> (raw)
In-Reply-To: <20260108172212.1402119-1-csander@purestorage.com>

bi_offload_capable() returns whether a block device's metadata size
matches its PI tuple size. Use pi_tuple_size instead of switching on
csum_type. This makes the code considerably simpler and less branchy.

Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
---
 block/bio-integrity-auto.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/block/bio-integrity-auto.c b/block/bio-integrity-auto.c
index 605403b52c90..626bbe17eb23 100644
--- a/block/bio-integrity-auto.c
+++ b/block/bio-integrity-auto.c
@@ -50,23 +50,11 @@ static bool bip_should_check(struct bio_integrity_payload *bip)
 	return bip->bip_flags & BIP_CHECK_FLAGS;
 }
 
 static bool bi_offload_capable(struct blk_integrity *bi)
 {
-	switch (bi->csum_type) {
-	case BLK_INTEGRITY_CSUM_CRC64:
-		return bi->metadata_size == sizeof(struct crc64_pi_tuple);
-	case BLK_INTEGRITY_CSUM_CRC:
-	case BLK_INTEGRITY_CSUM_IP:
-		return bi->metadata_size == sizeof(struct t10_pi_tuple);
-	default:
-		pr_warn_once("%s: unknown integrity checksum type:%d\n",
-			__func__, bi->csum_type);
-		fallthrough;
-	case BLK_INTEGRITY_CSUM_NONE:
-		return false;
-	}
+	return bi->metadata_size == bi->pi_tuple_size;
 }
 
 /**
  * __bio_integrity_endio - Integrity I/O completion function
  * @bio:	Protected bio
-- 
2.45.2


  parent reply	other threads:[~2026-01-08 17:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-08 17:22 [PATCH v2 0/3] block: zero non-PI portion of auto integrity buffer Caleb Sander Mateos
2026-01-08 17:22 ` [PATCH v2 1/3] " Caleb Sander Mateos
2026-01-09  5:51   ` Christoph Hellwig
2026-01-08 17:22 ` [PATCH v2 2/3] block: replace gfp_t with bool in bio_integrity_prep() Caleb Sander Mateos
2026-01-08 22:28   ` Anuj gupta
2026-01-09  5:52   ` Christoph Hellwig
2026-01-08 17:22 ` Caleb Sander Mateos [this message]
2026-01-08 22:39   ` [PATCH v2 3/3] block: use pi_tuple_size in bi_offload_capable() Anuj gupta
2026-01-09  5:53   ` Christoph Hellwig
2026-01-08 21:37 ` [PATCH v2 0/3] block: zero non-PI portion of auto integrity buffer Martin K. Petersen
2026-01-09 13:57 ` Jens Axboe
2026-01-09 16:29   ` Caleb Sander Mateos
2026-01-10 17:21     ` Jens Axboe
2026-01-10 17:28       ` Jens Axboe
2026-01-10 20:05       ` Caleb Sander Mateos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260108172212.1402119-4-csander@purestorage.com \
    --to=csander@purestorage.com \
    --cc=anuj20.g@samsung.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox