public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: colyli@fnnas.com
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
	Coly Li <colyli@fnnas.com>, Christoph Hellwig <hch@infradead.org>,
	Shida Zhang <zhangshida@kylinos.cn>,
	Kent Overstreet <kent.overstreet@linux.dev>
Subject: [PATCH] Revert "bcache: fix improper use of bi_end_io"
Date: Tue, 13 Jan 2026 14:09:39 +0800	[thread overview]
Message-ID: <20260113060940.46489-1-colyli@fnnas.com> (raw)

From: Coly Li <colyli@fnnas.com>

This reverts commit 53280e398471f0bddbb17b798a63d41264651325.

The above commit tries to address the race in bio chain handling,
but it seems in detached_dev_end_io() simply using bio_endio() to
replace bio->bi_end_io() may introduce potential regression.

This patch revert the commit, let's wait for better fix from Shida.

Signed-off-by: Coly Li <colyli@fnnas.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Shida Zhang <zhangshida@kylinos.cn>
Cc: Kent Overstreet <kent.overstreet@linux.dev>
---
 drivers/md/bcache/request.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
index 82fdea7dea7a..af345dc6fde1 100644
--- a/drivers/md/bcache/request.c
+++ b/drivers/md/bcache/request.c
@@ -1104,7 +1104,7 @@ static void detached_dev_end_io(struct bio *bio)
 	}
 
 	kfree(ddip);
-	bio_endio(bio);
+	bio->bi_end_io(bio);
 }
 
 static void detached_dev_do_request(struct bcache_device *d, struct bio *bio,
@@ -1121,7 +1121,7 @@ static void detached_dev_do_request(struct bcache_device *d, struct bio *bio,
 	ddip = kzalloc(sizeof(struct detached_dev_io_private), GFP_NOIO);
 	if (!ddip) {
 		bio->bi_status = BLK_STS_RESOURCE;
-		bio_endio(bio);
+		bio->bi_end_io(bio);
 		return;
 	}
 
@@ -1136,7 +1136,7 @@ static void detached_dev_do_request(struct bcache_device *d, struct bio *bio,
 
 	if ((bio_op(bio) == REQ_OP_DISCARD) &&
 	    !bdev_max_discard_sectors(dc->bdev))
-		detached_dev_end_io(bio);
+		bio->bi_end_io(bio);
 	else
 		submit_bio_noacct(bio);
 }
-- 
2.47.3


             reply	other threads:[~2026-01-13  6:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13  6:09 colyli [this message]
2026-01-13  8:07 ` [PATCH] Revert "bcache: fix improper use of bi_end_io" Christoph Hellwig
2026-01-13  8:30   ` Kent Overstreet
2026-01-13  8:34     ` Christoph Hellwig
2026-01-13  8:39       ` Kent Overstreet
2026-01-13  8:58         ` Christoph Hellwig
2026-01-13  9:27           ` Kent Overstreet
2026-01-13 15:00             ` Christoph Hellwig
2026-01-13 15:30               ` Kent Overstreet
2026-01-13 16:18           ` Coly Li
2026-01-13 16:26             ` Christoph Hellwig
2026-01-13 16:34               ` Kent Overstreet
2026-01-19  9:51                 ` Daniel Wagner
2026-01-19 10:18                   ` Kent Overstreet
2026-01-19 10:34                     ` Daniel Wagner
2026-01-19 15:57                       ` Daniel Wagner
2026-01-13 16:22   ` Coly Li
2026-01-13 16:25     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260113060940.46489-1-colyli@fnnas.com \
    --to=colyli@fnnas.com \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=kent.overstreet@linux.dev \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=zhangshida@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox