Re: [PATCH 11/14] iomap: rename IOMAP_DIO_DIRTY to IOMAP_DIO_USER_BACKED

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Jan 14, 2026 at 08:41:09AM +0100, Christoph Hellwig wrote:
> Match the more descriptive iov_iter terminology instead of encoding
> what we do with them for reads only.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Makes sense,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/iomap/direct-io.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
> index 6f7036e72b23..3f552245ecc2 100644
> --- a/fs/iomap/direct-io.c
> +++ b/fs/iomap/direct-io.c
> @@ -21,7 +21,7 @@
>  #define IOMAP_DIO_WRITE_THROUGH	(1U << 28)
>  #define IOMAP_DIO_NEED_SYNC	(1U << 29)
>  #define IOMAP_DIO_WRITE		(1U << 30)
> -#define IOMAP_DIO_DIRTY		(1U << 31)
> +#define IOMAP_DIO_USER_BACKED	(1U << 31)
>  
>  struct iomap_dio {
>  	struct kiocb		*iocb;
> @@ -214,7 +214,7 @@ static void __iomap_dio_bio_end_io(struct bio *bio, bool inline_completion)
>  {
>  	struct iomap_dio *dio = bio->bi_private;
>  
> -	if (dio->flags & IOMAP_DIO_DIRTY) {
> +	if (dio->flags & IOMAP_DIO_USER_BACKED) {
>  		bio_check_pages_dirty(bio);
>  	} else {
>  		bio_release_pages(bio, false);
> @@ -330,7 +330,7 @@ static ssize_t iomap_dio_bio_iter_one(struct iomap_iter *iter,
>  
>  	if (dio->flags & IOMAP_DIO_WRITE)
>  		task_io_account_write(ret);
> -	else if (dio->flags & IOMAP_DIO_DIRTY)
> +	else if (dio->flags & IOMAP_DIO_USER_BACKED)
>  		bio_set_pages_dirty(bio);
>  
>  	/*
> @@ -676,7 +676,7 @@ __iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter,
>  			goto out_free_dio;
>  
>  		if (user_backed_iter(iter))
> -			dio->flags |= IOMAP_DIO_DIRTY;
> +			dio->flags |= IOMAP_DIO_USER_BACKED;
>  
>  		ret = kiocb_write_and_wait(iocb, iomi.len);
>  		if (ret)
> -- 
> 2.47.3
> 
>