From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Cc: Caleb Sander Mateos <csander@purestorage.com>,
Uday Shankar <ushankar@purestorage.com>,
Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V6 01/24] ublk: define ublk_ch_batch_io_fops for the coming feature F_BATCH_IO
Date: Fri, 16 Jan 2026 22:18:34 +0800 [thread overview]
Message-ID: <20260116141859.719929-2-ming.lei@redhat.com> (raw)
In-Reply-To: <20260116141859.719929-1-ming.lei@redhat.com>
Introduces the basic structure for a batched I/O feature in the ublk driver.
It adds placeholder functions and a new file operations structure,
ublk_ch_batch_io_fops, which will be used for fetching and committing I/O
commands in batches. Currently, the feature is disabled.
Reviewed-by: Caleb Sander Mateos <csander@purestorage.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
drivers/block/ublk_drv.c | 26 +++++++++++++++++++++++++-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
index d1385f414bce..dfb5b1177cfd 100644
--- a/drivers/block/ublk_drv.c
+++ b/drivers/block/ublk_drv.c
@@ -263,6 +263,11 @@ static inline struct request *__ublk_check_and_get_req(struct ublk_device *ub,
u16 q_id, u16 tag, struct ublk_io *io);
static inline unsigned int ublk_req_build_flags(struct request *req);
+static inline bool ublk_dev_support_batch_io(const struct ublk_device *ub)
+{
+ return false;
+}
+
static inline struct ublksrv_io_desc *
ublk_get_iod(const struct ublk_queue *ubq, unsigned tag)
{
@@ -2679,6 +2684,12 @@ static int ublk_ch_uring_cmd(struct io_uring_cmd *cmd, unsigned int issue_flags)
return ublk_ch_uring_cmd_local(cmd, issue_flags);
}
+static int ublk_ch_batch_io_uring_cmd(struct io_uring_cmd *cmd,
+ unsigned int issue_flags)
+{
+ return -EOPNOTSUPP;
+}
+
static inline bool ublk_check_ubuf_dir(const struct request *req,
int ubuf_dir)
{
@@ -2798,6 +2809,16 @@ static const struct file_operations ublk_ch_fops = {
.mmap = ublk_ch_mmap,
};
+static const struct file_operations ublk_ch_batch_io_fops = {
+ .owner = THIS_MODULE,
+ .open = ublk_ch_open,
+ .release = ublk_ch_release,
+ .read_iter = ublk_ch_read_iter,
+ .write_iter = ublk_ch_write_iter,
+ .uring_cmd = ublk_ch_batch_io_uring_cmd,
+ .mmap = ublk_ch_mmap,
+};
+
static void ublk_deinit_queue(struct ublk_device *ub, int q_id)
{
struct ublk_queue *ubq = ub->queues[q_id];
@@ -2958,7 +2979,10 @@ static int ublk_add_chdev(struct ublk_device *ub)
if (ret)
goto fail;
- cdev_init(&ub->cdev, &ublk_ch_fops);
+ if (ublk_dev_support_batch_io(ub))
+ cdev_init(&ub->cdev, &ublk_ch_batch_io_fops);
+ else
+ cdev_init(&ub->cdev, &ublk_ch_fops);
ret = cdev_device_add(&ub->cdev, dev);
if (ret)
goto fail;
--
2.47.0
next prev parent reply other threads:[~2026-01-16 14:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 14:18 [PATCH V6 00/24] ublk: add UBLK_F_BATCH_IO Ming Lei
2026-01-16 14:18 ` Ming Lei [this message]
2026-01-16 14:18 ` [PATCH V6 02/24] ublk: prepare for not tracking task context for command batch Ming Lei
2026-01-16 14:18 ` [PATCH V6 03/24] ublk: add new batch command UBLK_U_IO_PREP_IO_CMDS & UBLK_U_IO_COMMIT_IO_CMDS Ming Lei
2026-01-16 14:18 ` [PATCH V6 04/24] ublk: handle UBLK_U_IO_PREP_IO_CMDS Ming Lei
2026-01-23 3:31 ` Jens Axboe
2026-01-16 14:18 ` [PATCH V6 05/24] ublk: handle UBLK_U_IO_COMMIT_IO_CMDS Ming Lei
2026-01-16 14:18 ` [PATCH V6 06/24] ublk: add io events fifo structure Ming Lei
2026-01-16 14:18 ` [PATCH V6 07/24] ublk: add batch I/O dispatch infrastructure Ming Lei
2026-01-23 3:32 ` Jens Axboe
2026-01-23 8:10 ` Ming Lei
2026-01-16 14:18 ` [PATCH V6 08/24] ublk: add UBLK_U_IO_FETCH_IO_CMDS for batch I/O processing Ming Lei
2026-01-16 14:18 ` [PATCH V6 09/24] ublk: refactor ublk_queue_rq() and add ublk_batch_queue_rq() Ming Lei
2026-01-23 3:04 ` Caleb Sander Mateos
2026-01-16 14:18 ` [PATCH V6 10/24] ublk: abort requests filled in event kfifo Ming Lei
2026-01-16 14:18 ` [PATCH V6 11/24] ublk: add new feature UBLK_F_BATCH_IO Ming Lei
2026-01-16 14:18 ` [PATCH V6 12/24] ublk: document " Ming Lei
2026-01-16 14:18 ` [PATCH V6 13/24] ublk: implement batch request completion via blk_mq_end_request_batch() Ming Lei
2026-01-16 14:18 ` [PATCH V6 14/24] ublk: fix batch I/O recovery -ENODEV error Ming Lei
2026-01-23 3:33 ` Jens Axboe
2026-01-16 14:18 ` [PATCH V6 15/24] selftests: ublk: fix user_data truncation for tgt_data >= 256 Ming Lei
2026-01-16 14:18 ` [PATCH V6 16/24] selftests: ublk: replace assert() with ublk_assert() Ming Lei
2026-01-16 14:18 ` [PATCH V6 17/24] selftests: ublk: add ublk_io_buf_idx() for returning io buffer index Ming Lei
2026-01-16 14:18 ` [PATCH V6 18/24] selftests: ublk: add batch buffer management infrastructure Ming Lei
2026-01-16 14:18 ` [PATCH V6 19/24] selftests: ublk: handle UBLK_U_IO_PREP_IO_CMDS Ming Lei
2026-01-16 14:18 ` [PATCH V6 20/24] selftests: ublk: handle UBLK_U_IO_COMMIT_IO_CMDS Ming Lei
2026-01-16 14:18 ` [PATCH V6 21/24] selftests: ublk: handle UBLK_U_IO_FETCH_IO_CMDS Ming Lei
2026-01-16 14:18 ` [PATCH V6 22/24] selftests: ublk: increase timeout to 150 seconds Ming Lei
2026-01-16 14:18 ` [PATCH V6 23/24] selftests: ublk: add --batch/-b for enabling F_BATCH_IO Ming Lei
2026-01-16 14:18 ` [PATCH V6 24/24] selftests: ublk: support arbitrary threads/queues combination Ming Lei
2026-01-23 2:24 ` [PATCH V6 00/24] ublk: add UBLK_F_BATCH_IO Ming Lei
2026-01-23 3:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260116141859.719929-2-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=linux-block@vger.kernel.org \
--cc=ushankar@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox