public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: John Garry <john.g.garry@oracle.com>,
	Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>
Subject: Re: [PATCH 1/2] block: Annotate the queue limits functions
Date: Mon, 19 Jan 2026 09:41:43 +0100	[thread overview]
Message-ID: <20260119084143.GA5509@lst.de> (raw)
In-Reply-To: <33fe1cf9-a779-427b-bf74-1eee4434517c@acm.org>

On Thu, Jan 15, 2026 at 08:53:32AM -0800, Bart Van Assche wrote:
> On 1/15/26 1:11 AM, John Garry wrote:
>> On 15/01/2026 06:26, Christoph Hellwig wrote:
>>> This is missing a commit log.  And not really telling what kind
>>> of annotation you're adding.
>>
>> And we removed these previously - see c3042a5403ef2.
>>
>> Does sparse now handle mutexes?
>
> sparse is dead.

It's not.  And even if it was we still need it.

> The most recent commit is from February 2024 (almost two
> years ago).

The repository disagrees:

commit fbdde3127b83e6d09e0ba808d7925dd84407f3c6 (origin/master, origin/HEAD)
Author: Dan Carpenter <dan.carpenter@linaro.org>
Date:   Wed Oct 15 16:08:13 2025 +0300

    builtin: implement __builtin_strlen() for constants


> Additionally, the sparse maintainer doesn't reply anymore to
> emails or bug reports about sparse.

While I'd love to see more activity, that is clearly untrue as well:

[PATCH v2 3/3] module: Add compile-time check for embedded NUL characters


> These annotations aren't for sparse - these are for clang. This patch 
> series has been queued by Peter Zijlstra on the tip master branch and is
> expected to be sent to Linus during the next merge window: "[PATCH v5
> 00/36] Compiler-Based Context- and Locking-Analysis"
> (https://lore.kernel.org/lkml/20251219154418.3592607-1-elver@google.com/).

Until that actually becomes mainstream we can't break the existing
annotations.


  reply	other threads:[~2026-01-19  8:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-14 19:28 [PATCH 0/2] Fix an error path in disk_update_zone_resources() Bart Van Assche
2026-01-14 19:28 ` [PATCH 1/2] block: Annotate the queue limits functions Bart Van Assche
2026-01-15  6:26   ` Christoph Hellwig
2026-01-15  8:11     ` John Garry
2026-01-15 16:53       ` Bart Van Assche
2026-01-19  8:41         ` Christoph Hellwig [this message]
2026-01-20 13:42           ` Bart Van Assche
2026-01-14 19:28 ` [PATCH 2/2] block: Fix an error path in disk_update_zone_resources() Bart Van Assche
2026-01-15  6:26   ` Christoph Hellwig
2026-01-19 18:04 ` (subset) [PATCH 0/2] " Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260119084143.GA5509@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=dlemoal@kernel.org \
    --cc=john.g.garry@oracle.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox