Re: [PATCH 09/15] iomap: pass the iomap_iter to ->submit_read

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Jan 21, 2026 at 07:43:17AM +0100, Christoph Hellwig wrote:
> This provides additional context for file systems.
> 
> Rename the fuse instance to match the method name while we're at it.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks fine, will probably have more comments when we start accessing the
iter...

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/fuse/file.c         | 5 +++--
>  fs/iomap/bio.c         | 3 ++-
>  fs/iomap/buffered-io.c | 4 ++--
>  include/linux/iomap.h  | 3 ++-
>  4 files changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index 01bc894e9c2b..99b79dc876ea 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -947,7 +947,8 @@ static int fuse_iomap_read_folio_range_async(const struct iomap_iter *iter,
>  	return ret;
>  }
>  
> -static void fuse_iomap_read_submit(struct iomap_read_folio_ctx *ctx)
> +static void fuse_iomap_submit_read(const struct iomap_iter *iter,
> +		struct iomap_read_folio_ctx *ctx)
>  {
>  	struct fuse_fill_read_data *data = ctx->read_ctx;
>  
> @@ -958,7 +959,7 @@ static void fuse_iomap_read_submit(struct iomap_read_folio_ctx *ctx)
>  
>  static const struct iomap_read_ops fuse_iomap_read_ops = {
>  	.read_folio_range = fuse_iomap_read_folio_range_async,
> -	.submit_read = fuse_iomap_read_submit,
> +	.submit_read = fuse_iomap_submit_read,
>  };
>  
>  static int fuse_read_folio(struct file *file, struct folio *folio)
> diff --git a/fs/iomap/bio.c b/fs/iomap/bio.c
> index 578b1202e037..cb60d1facb5a 100644
> --- a/fs/iomap/bio.c
> +++ b/fs/iomap/bio.c
> @@ -18,7 +18,8 @@ static void iomap_read_end_io(struct bio *bio)
>  	bio_put(bio);
>  }
>  
> -static void iomap_bio_submit_read(struct iomap_read_folio_ctx *ctx)
> +static void iomap_bio_submit_read(const struct iomap_iter *iter,
> +		struct iomap_read_folio_ctx *ctx)
>  {
>  	struct bio *bio = ctx->read_ctx;
>  
> diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
> index 6beb876658c0..4a15c6c153c4 100644
> --- a/fs/iomap/buffered-io.c
> +++ b/fs/iomap/buffered-io.c
> @@ -573,7 +573,7 @@ void iomap_read_folio(const struct iomap_ops *ops,
>  				&bytes_submitted);
>  
>  	if (ctx->ops->submit_read)
> -		ctx->ops->submit_read(ctx);
> +		ctx->ops->submit_read(&iter, ctx);
>  
>  	iomap_read_end(folio, bytes_submitted);
>  }
> @@ -637,7 +637,7 @@ void iomap_readahead(const struct iomap_ops *ops,
>  					&cur_bytes_submitted);
>  
>  	if (ctx->ops->submit_read)
> -		ctx->ops->submit_read(ctx);
> +		ctx->ops->submit_read(&iter, ctx);
>  
>  	if (ctx->cur_folio)
>  		iomap_read_end(ctx->cur_folio, cur_bytes_submitted);
> diff --git a/include/linux/iomap.h b/include/linux/iomap.h
> index ea79ca9c2d6b..bf6280fc51af 100644
> --- a/include/linux/iomap.h
> +++ b/include/linux/iomap.h
> @@ -512,7 +512,8 @@ struct iomap_read_ops {
>  	 *
>  	 * This is optional.
>  	 */
> -	void (*submit_read)(struct iomap_read_folio_ctx *ctx);
> +	void (*submit_read)(const struct iomap_iter *iter,
> +			struct iomap_read_folio_ctx *ctx);
>  };
>  
>  /*
> -- 
> 2.47.3
> 
>